Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing externalRef #5

Open
tboenig opened this issue Jul 25, 2022 · 9 comments
Open

Missing externalRef #5

tboenig opened this issue Jul 25, 2022 · 9 comments

Comments

@tboenig
Copy link

tboenig commented Jul 25, 2022

Hi,
I miss the externalRef on the following documents or a stabile link to image file:

  • PPN477380670
  • PPN477396054
  • PPN477396569

Thanks a lot.

@stweil
Copy link
Member

stweil commented Jul 25, 2022

Those last three contributions are work in progress. For example the files must be renamed to match our naming schema, and they are still missing in the README. The externalRef is added automatically for images which were imported in eScriptorium via IIIF URL, but here PDF files were imported, and I still have to check whether the image size from the PDF matches the maximum image size of the page scans.

@stweil
Copy link
Member

stweil commented Jul 25, 2022

I now updated the README with links to the new contributions.

@tboenig
Copy link
Author

tboenig commented Jul 25, 2022

but here PDF files were imported, and I still have to check whether the image size from the PDF matches the maximum image size of the page scans.externalRef

😮 PDF 😮

I have (spot) checked PPN477396054. Unfortunately, the linking is not correct there and the size is not correct either. As nice as PDF is sometimes but you get into unintended trouble with it.

@tboenig
Copy link
Author

tboenig commented Jul 25, 2022

Be careful, you doubled the quotation marks.
Example:
<Page imageFilename="477396054_0005.jpg"" imageWidth="1965" imageHeight="2580">

@stweil
Copy link
Member

stweil commented Jul 25, 2022

That was fixed meanwhile. Also fixed now: PPN477396569, PPN477396054, PPN477380670.

@stweil
Copy link
Member

stweil commented Jul 26, 2022

I think the issue is fixed now and can be closed.

@tboenig
Copy link
Author

tboenig commented Jul 26, 2022

Thank you very much.
I have forked the data. Here is my result:

@stweil
Copy link
Member

stweil commented Jul 27, 2022

Should we update our repository to minimize the differences to your fork? Which changes would you suggest?
And is your fork updated automatically when we add more ground truth (additional pages, additional books)?

Note that the data also contains a small amount of Greek texts.

@stweil
Copy link
Member

stweil commented Jul 27, 2022

@tboenig, maybe you noticed that there is another new repository with ground truth for which your suggestions are also welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants