Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[presentation] Fix handling of hashed pages #18

Open
stweil opened this issue Aug 2, 2022 · 1 comment
Open

[presentation] Fix handling of hashed pages #18

stweil opened this issue Aug 2, 2022 · 1 comment
Assignees
@csidirop
Labels
bug Something isn't working presentation Issue concerns Kitodo.Presentation

Comments

@stweil
Copy link
Member

stweil commented Aug 2, 2022

Test case:

  1. Run OCR for page n.
  2. Run OCR for whole book.

Now the presentation shows the fulltext for most pages without further user interaction. It also displays the selector for the fulltext display on/off and does not show the buttons for OCR on demand.

For page n the fulltext is only shown after pressing the OCR on demand button.

Potential fix:

Remove the cHash part in the URL for page n. Then the fulltext is shown like for other pages. So either the old hash for that page and create a new one, or – maybe better and easier – don't use hashing for all presentation pages.

See also
@stweil stweil added the bug Something isn't working label Aug 2, 2022
@csidirop csidirop changed the title Fix handling of hashed pages [presentation] Fix handling of hashed pages Aug 3, 2022
@csidirop csidirop added the presentation Issue concerns Kitodo.Presentation label Aug 3, 2022
@csidirop
Copy link
Member

For the record: Adding all remaining presentation related parametes has no effect.

'tx_dlf[id]',
'set[mets]',
#additional:
'tx__[action]',
'tx__[controller]',
'tx_dlf[page]',
'tx_dlf[double]',
'tx_dlf[pagegrid]'

csidirop added a commit to csidirop/kitodo-presentation that referenced this issue Dec 6, 2022
@csidirop
Workaround to circumvent TYPO3 disturbing caching
99a3038 
 - Clear the stored page cache (for presentations viewer only!) on calling

UB-Mannheim/kitodo-presentation-docker#18
Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
csidirop added a commit to csidirop/kitodo-presentation that referenced this issue Jan 24, 2023
@csidirop
Squashed commit of the following:
f3072c5 
commit f6866a5
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Jan 11 14:45:17 2023 +0000

    Simplify and cleanup OCR scripts

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit e30eb0e
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Jan 11 14:40:41 2023 +0000

    Update kraken script

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit ded8bb4
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Dec 23 14:42:02 2022 +0000

    Add support for kraken

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit fef103e
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Dec 16 08:26:03 2022 +0000

    Format

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit d35797e
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Dec 15 16:04:12 2022 +0000

    Check server protocol

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 786d381
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Dec 15 14:52:01 2022 +0000

    Temporally disable log writing again

    UB-Mannheim/kitodo-presentation-docker#34
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit f325efc
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Dec 15 15:50:18 2022 +0100

    Fix issue with ocrengine-cookie not beeing checked correctly

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit f984d79
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Dec 15 14:15:51 2022 +0100

    Remove second Tesseract entry

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 729ed33
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Dec 14 13:51:04 2022 +0000

    Update OCRD Workflow

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit a061f41
Merge: cfd4a5c 790ade9
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Dec 7 09:33:53 2022 +0000

    Merge commit '790ade991ee0917b800e05e04ab774740b3f26f7' into feature/MultiOCRengines

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit cfd4a5c
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Dec 7 08:33:15 2022 +0000

    Make scripts executable

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 99a3038
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Dec 6 16:09:35 2022 +0100

    Workaround to circumvent TYPO3 disturbing caching

     - Clear the stored page cache (for presentations viewer only!) on calling

    UB-Mannheim/kitodo-presentation-docker#18
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 790ade9
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Dec 6 09:58:43 2022 +0100

    Remove obsolete code

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 2816a42
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Dec 2 14:14:05 2022 +0100

    Update OCRD script

     - add variable
     - fix typo in command
     - clean working dir

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit cb97163
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Dec 1 16:35:31 2022 +0100

    Add OCRD-Engine

     - first implementation of OCRD-script

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 64be5e6
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Dec 1 11:59:55 2022 +0100

    Rewrite of ocr-lock

     - run lock-block befor anything else

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit a4b342a
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Dec 1 10:41:44 2022 +0100

    Add proper errorhandling when OCR fails

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit e44baa2
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Dec 1 09:16:46 2022 +0100

    Rewrite of ocr-lock

     - Follow 'ocrLock' rule
     - minor changes

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit e969d23
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Nov 30 18:14:36 2022 +0100

    Rewrite of ocr-lock

     - allow to set a max for parallel OCR jobs
     - if there is already a lock set, return

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 0ba2f29
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Nov 30 16:55:50 2022 +0100

    Rewrite of ocr-lock

     - restructure temp folder structure
     - use unique lock per job
       -> more than one OCR at on time possible
       -> but only one per page/image
     - moved to file based locks

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit cabe044
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Nov 30 15:26:55 2022 +0100

    Rewrite of ocr-lock

     - locking is now non blocking (exept for OCR gen)

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 3bff9a7
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Nov 30 14:49:00 2022 +0100

    Rewrite of ocr-lock

     - locking is now done in PHP and not part of the shell command
     - cleaner and less error prune

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 54132ae
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Mon Nov 28 10:34:33 2022 +0100

    Let ocr engine script fail, if an error occur

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit e67216c
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Nov 22 15:28:31 2022 +0100

    Small changes

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit a76acf8
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Nov 17 13:20:22 2022 +0100

    Correct syntax of the setcookie function

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit cbe89a2
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Nov 16 16:44:49 2022 +0100

    Make sure OCR Engine ist valid

     - check if ocr engine selected by the user is valid
     - Fullfilles two goals:
      - orc engine is valid and can be called
      - no remote shell ececution can be executed
       - this could happen because the selected engine is stored as cookie
       - this cookie could be tempered to execute malicious commands when passed to the console

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit d386ce4
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Nov 16 12:59:50 2022 +0100

    Remove file extensions from json

    Those led to errors in DFG Viewer

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 6c32983
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Nov 16 10:33:14 2022 +0100

    OCR Cookies: Use SameSite=None

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 99326c0
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Nov 15 16:58:21 2022 +0100

    Allow selection of different OCR engines

     - active engines are stored in a json file
     - engines get written into a cookie allowing FE to read them
     - add an option to set an alternative Path for the json file

    UB-Mannheim/kitodo-presentation-docker#20
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit e381284
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Nov 15 14:11:27 2022 +0100

    Parse OCR Engines and write to cookies

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 52a27bf
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Nov 15 11:10:46 2022 +0100

    Cleanup

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 080830c
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Nov 15 09:18:33 2022 +0100

    Declare nullable return type

     - Declare nullable return type string, because its null when no URN found
     - init the string with null

    In addition to 220a173

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 220a173
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Nov 11 15:31:39 2022 +0100

    Add type declarations for project specific php files

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit a6ffb05
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Nov 11 12:39:56 2022 +0100

    Codecleanup: Move all XML components to on class

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 7f7c23e
Merge: 38dc5e2 130d8a6
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Nov 10 16:14:31 2022 +0100

    Merge branch 'feature/updateXML' into 3.3.x-ocr

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 38dc5e2
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Nov 8 16:58:11 2022 +0100

    Break out the loop if valid URN found

    -> Less error-prone and faster

    UB-Mannheim/kitodo-presentation-docker#32
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 35cf954
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Nov 8 16:56:41 2022 +0100

    Find URN additionaly in "mets:div" tag

    This is necessary for some METS sources, which do not have there URNs stored elsewhere.

    UB-Mannheim/kitodo-presentation-docker#32
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit bf112d3
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Nov 8 15:14:16 2022 +0100

    Find URN additionaly in "identifier" tag

    This is necessary for METS sources from BVB, wich do not have "mods:identifier" tag.

    UB-Mannheim/kitodo-presentation-docker#32
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 9397042
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Nov 4 11:33:37 2022 +0100

    Parse URNs stored under 'mods:recordIdentifier'

    UB-Mannheim/kitodo-presentation-docker#32
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 51741b6
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Nov 4 11:23:30 2022 +0100

    Cleanup URN generation

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 250d3ad
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Nov 3 13:03:16 2022 +0100

    Change loop var so it includes the last element

    Fixes UB-Mannheim/kitodo-presentation-docker#31

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 130d8a6
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Oct 27 14:47:10 2022 +0200

    Update existing METS structMap PHYSICAL entries

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 92b4ad9
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Oct 27 13:09:04 2022 +0200

    Update existing METS FULLTEXT entries

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit d5231e3
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Oct 27 10:27:38 2022 +0200

    Add SOFTWARE attribute and code cleanup

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 31fca81
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Oct 26 16:34:06 2022 +0200

    Add variables and more details

     - URL
     - ID
     - CREATED

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 52fa50a
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Oct 26 16:25:36 2022 +0200

    Remove comments

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit fa762e6
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Oct 25 16:57:01 2022 +0200

    Add tmp dependency

    Hopefully there is a way without an extra dep.

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit bf7a4d0
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Oct 25 16:54:36 2022 +0200

    Update METS XML with new FULLTEXT entries

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 23e9bad
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Oct 21 12:29:01 2022 +0200

    Add METS path variable and update functions

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 4c345d4
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Oct 20 15:02:33 2022 +0200

    Remove old comments and unnecessary debug echos

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 4954c81
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Oct 20 15:00:11 2022 +0200

    Use absolute instead of relative urls for local fulltext path

    UB-Mannheim/kitodo-presentation-docker#19
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit ba71788
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Oct 19 16:21:48 2022 +0200

    Add different modes for getImage():

     - default mode which is how it was before
     - OCR mode which gets the highest quallity
     - changed the way how the array was iterated through:
       - instead of array_pop() use a classical for-loop
       - this way, we can iterate in both directions
       - Implementation could be improved
      - this only works if DFG-Viewer is not overwriting the config: csidirop/dfg-viewer@1eea953
      - Remove old comments

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 3963e84
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Oct 14 14:50:37 2022 +0200

    Update extension options and add german translations

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 8264432
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Oct 13 16:52:35 2022 +0200

    Preperation for multi OCR-Engine

     - use subfolder with engine name for OCR results
     - hold the 'ocrEngine' in session globaly for this user
       - using PHP sessions for this (there are maybe better solutions...)

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit f179c62
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Oct 12 10:10:11 2022 +0200

    Remove sleep delay interval multiplier

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit db3779f
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Oct 6 11:34:02 2022 +0200

    Write METS XML _after_ creating folder structure

    Fixes error when structure is not present ...

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 733fb5e
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Sep 22 10:31:13 2022 +0200

    Small changes

    - remove old obsolete code
    - add $ocr_script parameter to method for later

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 61f7479
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Mon Sep 19 12:38:30 2022 +0200

    Add clearer error message when METS file writing fails

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 2660c6d
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Mon Sep 19 12:21:37 2022 +0200

    Add another way to get the METS file

     - get the METS from doc object instead of redownloading it from the remote server
     - faster
     - less traffic
     - header changes slightly, needs more investigations
     - line is commented out

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 31dd2c2
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Mon Sep 19 10:37:39 2022 +0200

    Store the METS XML file beside the fulltext ALTO files

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 5da3bf2
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Mon Sep 19 10:17:36 2022 +0200

    Remove OCR-Test & KIT reference

    - Its not a test anymore.
    - Code changed a lot since my KIT copy tests

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 1fbdde9
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Sep 16 15:27:45 2022 +0200

    Update comment

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 08a7f0b
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Sep 16 11:59:35 2022 +0200

    Small fix to 59342fb

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 59342fb
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Sep 16 11:35:44 2022 +0200

    Change OCR result path to contain urn

    - Path is now not only unique, but recognizable
    - Path consists of docs URN
    -> URN/nbn/de/bsz/180/digosi/30
    - One downsite: Mets file is reparsed

    UB-Mannheim/kitodo-presentation-docker#24
    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit c58ede3
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Sep 1 15:41:02 2022 +0200

    Change naming

    use more obvious var names
    - $doc_path -> $outputFolder_path
    - $xml_path -> $output_path
    - $temp_xml_path -> $temp_output_path

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit c407d0a
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Aug 30 14:43:05 2022 +0200

    Small changes

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 5e9076d
Merge: 665b82b db1e532
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Aug 26 16:38:37 2022 +0200

    Merge commit 'db1e53252080a343668c769bedc649f99ed28057' into 3.3.x-ocr

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit db1e532
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Aug 26 16:37:05 2022 +0200

    Tmporarily use sha hash as folderstructure

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 015f0ba
Merge: 4ec6750 665b82b
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Aug 26 11:11:53 2022 +0200

    Merge branch '3.3.x-ocr' into urn-edit

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 665b82b
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Aug 25 12:23:45 2022 +0200

    Code cleanup:

     - merge similar code sections
     - add more documentation
     - more clearly
     - naming sheme

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 4ec6750
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Aug 24 15:59:23 2022 +0200

    Store OCR results using unique path

     - get urn from mets file
     - create path
     - use path

     - works not on every mets file
     - sha hash missing

     UB-Mannheim/kitodo-presentation-docker#24

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 2a01c78
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Aug 23 17:32:58 2022 +0200

    Small changes

    - remove unused code and comments
    - add more detailed comments
    - move debug
    - code cleanup

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit ec10eb4
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Aug 23 17:23:34 2022 +0200

    Change booleans from true/false to binary 1/0

    And add spaces around =

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit b44d1aa
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Aug 19 16:26:58 2022 +0200

    Code cleanup

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 2b49522
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Aug 19 16:08:13 2022 +0200

    Add option to gen ocr without dowloading  images

    - script now can handle paths and URLS
    - FullTextGenerator now checks if it should download the image or pass the URL to tesseract
    - add an option in backend to toggle whether the images should be downloaded
    - not predownloading the images solves this issue: UB-Mannheim/kitodo-presentation-docker#22
    - script checks if images are present. One part of: UB-Mannheim/kitodo-presentation-docker#23

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 57f18b3
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Aug 19 09:43:23 2022 +0200

    Remove unused vars

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit cd3e8ec
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Aug 18 18:01:50 2022 +0200

    Code cleanup

    - move ocr shell command gen to own func

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 1685b59
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Aug 18 15:25:20 2022 +0200

    Add parameter descriptions

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit b6078c7
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Aug 16 17:14:28 2022 +0200

    Add end of file newline

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 5520909
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Aug 16 17:12:31 2022 +0200

    Code refactoring: FullTextGenerator.php

    - streamline (sort of... not finished)
    - move code
    - add/remove comments
    - code cleanup

    -> UB-Mannheim/kitodo-presentation-docker#20

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 57ca9f2
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Fri Aug 12 15:54:25 2022 +0200

    Code cleanup and debug prints

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit e4ae584
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Aug 11 16:49:41 2022 +0200

    Move ocr engine out to script

     - first step
     - all tesseract calls now moved inside the script
     - there is a new folder for more scripts and more engines and more
     - the will only call the scripts

     -> UB-Mannheim/kitodo-presentation-docker#20

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 6af17fc
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Thu Jul 21 16:22:28 2022 +0200

    Temporally disable all alerts in js-files

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 2914cfa
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Jul 12 16:33:51 2022 +0200

    Revert pathname

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 44538bc
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Jul 12 16:06:33 2022 +0200

    Update backend settings

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 13be731
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Jul 12 16:05:00 2022 +0200

    Update backend settings

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit 340d046
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Jul 12 15:53:14 2022 +0200

    Update backend settings

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit c3f0a5c
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue Jul 12 15:50:09 2022 +0200

    Change default fulltextfolder

    Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>

commit c0478d9
Author: Christos <csidirop@runbox.com>
Date:   Tue Jul 5 14:46:31 2022 +0200

    Correct/revert path

commit 5dd0050
Author: Christos <csidirop@runbox.com>
Date:   Tue Jul 5 11:53:09 2022 +0200

    Change titles after merge

commit 41504f1
Merge: 45a71fe afb8a54
Author: Christos <csidirop@runbox.com>
Date:   Tue Jul 5 11:51:46 2022 +0200

    Merge branch '3.3.x-ocr-test' into 3.3.x-ocr

commit afb8a54
Merge: 921fbd9 bea1de2
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Jun 1 08:10:24 2022 +0000

    Merge branch '3.3.x-ocr-test' of github.com:csidirop/kitodo-presentation into 3.3.x-ocr-test

commit 921fbd9
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Jun 1 08:10:19 2022 +0000

    Update/revert version

commit bea1de2
Author: Chris <csidirop@runbox.com>
Date:   Wed Jun 1 10:04:26 2022 +0200

    Correct/revert path

commit 0e85aef
Author: Chris <csidirop@runbox.com>
Date:   Wed Jun 1 09:52:49 2022 +0200

    Correct/revert path

commit 17668dc
Merge: 19504dd 5d6ab85
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Jun 1 07:24:41 2022 +0000

    Merge branch '3.3.x-ocr-test' of github.com:csidirop/kitodo-presentation into 3.3.x-ocr-test

commit 19504dd
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Jun 1 07:24:34 2022 +0000

    Set state to dev and revert version

commit eed54b9
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Wed Jun 1 07:24:00 2022 +0000

    Change debug messages

commit 5d6ab85
Author: Chris <csidirop@runbox.com>
Date:   Wed Jun 1 08:34:08 2022 +0200

    Additional composer tests

    Alphanumeric versionnumber to numeric versionnumber

commit c76ffd5
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue May 31 13:56:16 2022 +0000

    OCR-On-Demand branches restructuring

commit c58a81e
Author: Christos Sidiropoulos <csidirop@runbox.com>
Date:   Tue May 31 13:23:54 2022 +0000

    OCR-On-Demand branches restructuring & small changes

commit 59e1be1
Author: Chris <csidirop@runbox.com>
Date:   Tue May 24 13:18:18 2022 +0200

    Further tests

commit 5538ca9
Author: csidirop <csidirop@runbox.com>
Date:   Fri Apr 29 16:29:30 2022 +0200

    Composer Test

commit 74a0416
Author: csidirop <csidirop@runbox.com>
Date:   Fri Apr 29 12:06:22 2022 +0200

    Composer Test

commit ef32fcb
Author: Christos <csidirop@runbox.com>
Date:   Tue Apr 26 16:09:09 2022 +0200

    Updated composer.json

commit 73219bd
Author: Christos <csidirop@runbox.com>
Date:   Tue Apr 26 16:01:16 2022 +0200

    Updated composer.json

commit 45a71fe
Author: Christos <csidirop@runbox.com>
Date:   Tue Apr 26 15:58:32 2022 +0200

    Updated composer.json

commit e6f3ba2
Author: Christos <csidirop@runbox.com>
Date:   Tue Apr 26 13:14:08 2022 +0200

    Preview with errors

commit 4a20621
Merge: b9df5c6 0987201
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Tue Feb 15 10:47:15 2022 +0100

    Merge pull request kitodo#766 from kitodo/prepare-3.3.4

    Security fix and preparation for release 3.3.4 - please update!

commit 0987201
Author: Kajetan Dvoracek <kajetan.dvoracek@slub-dresden.de>
Date:   Tue Feb 15 10:03:17 2022 +0100

    Security fix and preparation for release 3.3.4 - please update!

commit b9df5c6
Merge: 8d3ff8e a3d4f15
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Tue Jan 11 12:00:59 2022 +0100

    Merge pull request kitodo#755 from albig/prepare-3.3.3

    Prepare Release 3.3.3

commit a3d4f15
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Mon Jan 10 17:09:41 2022 +0100

    Merge pull request kitodo#752 from albig/fix-751

    Set owner correctly on (re-) indexing documents.

commit 8662fe3
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Mon Jan 10 13:58:19 2022 +0100

    Merge pull request kitodo#753 from albig/fix-indexing-empty-fulltext-2

    It may happen, that fulltext files are empty. In this case, indexing should not abort with exception.

commit 58256bf
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Mon Jan 10 17:03:58 2022 +0100

    Rise version number

commit 8d3ff8e
Merge: 0cd1e90 65786cc
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Thu Dec 23 19:40:06 2021 +0100

    Merge pull request kitodo#749 from albig/prepare-3.3.2

    Prepare Bugfix release 3.3.2

commit 65786cc
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Thu Dec 23 17:46:02 2021 +0100

    Rise version number

commit a1084f5
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Thu Dec 23 16:31:45 2021 +0100

    Merge pull request kitodo#748 from beatrycze-volk/fix-link-search

    Fix link creation for configured slug

commit 0cd1e90
Merge: fd5a9f6 c963dbf
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Tue Nov 16 10:14:56 2021 +0100

    Merge pull request kitodo#738 from albig/cherry-pick-736

    Fix logger in MetsDocument and IiifManifest

commit c963dbf
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Tue Nov 16 09:45:44 2021 +0100

    Rise version number

commit 8d006e0
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Fri Nov 12 15:09:23 2021 +0100

    Fix logger in MetsDocument and IiifManifest

    The $this->logger is currently `null` in both classes.

commit fd5a9f6
Merge: 930e22c 186bdc1
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Wed Oct 20 15:36:47 2021 +0200

    Merge pull request kitodo#706 from albig/cherry-pick-699

    Quick Fix: Wait for `tx_dlf_viewer` when highlighting word

commit 186bdc1
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Wed Oct 20 12:47:23 2021 +0200

    Merge pull request kitodo#699 from dvoracek-slub/fix-highlight-word

    Quick Fix: Wait for `tx_dlf_viewer` when highlighting word

commit 930e22c
Merge: 4f3247e d7602a2
Author: Alexander Bigga <alexander.bigga@slub-dresden.de>
Date:   Mon Oct 18 09:40:49 2021 +0200

    Merge pull request kitodo#695 from albig/cherrypick-693

    Refactor check for fulltext into utility function

commit d7602a2
Author: Kajetan Dvoracek <kajetan.dvoracek@slub-dresden.de>
Date:   Thu Oct 14 11:13:55 2021 +0200

    Refactor check for fulltext into utility function

    Empty arrays are now ruled out be the condition `'url' in obj`.

Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csidirop csidirop

Labels
bug Something isn't working presentation Issue concerns Kitodo.Presentation
Projects
OCR-D Kitodo.Presentation
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stweil @csidirop