Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--head option isn't guaranteed to resample to 344x344 #14

Open
ashgillman opened this issue May 22, 2018 · 2 comments
Open

--head option isn't guaranteed to resample to 344x344 #14

ashgillman opened this issue May 22, 2018 · 2 comments

Comments

@ashgillman
Copy link
Contributor

In fact, out MRAC acquisitions aren't the same size in x and y directions, so nm_mrac2mu actually produces different sizes in x and y, which is not compatible with certain aspects of STIR.

Sorry for repeating, I think I have mentioned this in a previous issue, but I am creating a new one to make a PR against :)

Ash

@KrisThielemans
Copy link
Collaborator

not sure which bits of STIR are failing with the size. it should disable symmetries in the projector, but will still work (with more memory). of course calculate_atenuation_coefficients still needs the --PMRT switch but I'm changing that (or have done it already?).

Note that we really need to add z-position info into STIR sinograms and then take it into account in images. Then hopefully most of this trouble will disappear.

@ashgillman
Copy link
Contributor Author

In estimate_scatter.sh, rather zoom_att_image.sh.
https://github.com/UCL/STIR/blob/master/scripts/zoom_att_image.sh

Perhaps this has been rectified and those checks can be removed?

bathomas added a commit that referenced this issue May 30, 2018
Partial fix for #14 Adjust x-y padding (with --head) to meet default size.
ashgillman pushed a commit to ashgillman/petmr-rd-tools that referenced this issue Nov 12, 2019
Use mark_as_superbuild to pass generator, platform info etc. This will
partial solve Issue UCL#14 (but only for dependencies that build via CMake).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants