Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There might be a typo in your code #9

Open
SingleCellW opened this issue Aug 12, 2024 · 1 comment
Open

There might be a typo in your code #9

SingleCellW opened this issue Aug 12, 2024 · 1 comment

Comments

@SingleCellW
Copy link

In lotus\skill_learning\skill_discovery\hierarchical_agglomoration.py file Line 49,
the judgement in dataset_category has a typo, where 'libero_spactial' should be 'libero_spatial',
or demostations in project's README would not work.

Please fix it, thanks.

@SingleCellW
Copy link
Author

Hi there, there may be more typos in code,
In first several lines in agglomoration_script.py file, dataset_name_list should be changed to the right tasks.
While Spectral Clustering, add footprint in the final part should make it work, like "agglomoration.footprint=global_pooling".
And there'd better be a mem release in the last part of hierarchical_agglomoration_utils.py,
like "plt.cla()", "plt.close("all")" to avoid wasted mem (my 32GB mem v-server may not be suffice).

It's a little painstaking to work through the README part, but still great work, appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant