Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Section" class seems to be the only label for body text #134

Open
cambro opened this issue Oct 27, 2020 · 3 comments
Open

"Section" class seems to be the only label for body text #134

cambro opened this issue Oct 27, 2020 · 3 comments
Labels
API Related to external interfaces with e.g. the COSMOS visualizer question Further information is requested

Comments

@cambro
Copy link
Contributor

cambro commented Oct 27, 2020

Using this response as guide:
https://xdddev.chtc.io/sets/xdd-covid-19/api/v2_beta/search?query=Remdesivir,MERS&inclusive=true&ignore_bytes=true

There are a ton of text blocks returned here with cls=section, that are clearly not sections.

Trying to be explicit:
https://xdddev.chtc.io/sets/xdd-covid-19/api/v2_beta/search?query=Remdesivir,MERS&inclusive=true&ignore_bytes=true&type=Body%20Text

All of the cls values are still "Section.

Making the search more general:
https://xdddev.chtc.io/sets/xdd-covid-19/api/v2_beta/search?query=Remdesivir&inclusive=true&ignore_bytes=true
There are some cls="equation" objects that seem to be large text blocks too, along with abundant cls="Section".

@cambro cambro added question Further information is requested API Related to external interfaces with e.g. the COSMOS visualizer labels Oct 27, 2020
@iross
Copy link
Contributor

iross commented Oct 30, 2020

(note to avoid future confusion: URLs now need /xdd-covid-19/cosmos/api..)

@ankur-gos
Copy link
Contributor

Sections are now the "Processed" version of body text, similar to how Figures are both Figures and captions and Tables are tables and captions.

Likewise, "Equations" is the processed form for equation, which are the equation itself and the content around the equation to enable better searching.

@cambro
Copy link
Contributor Author

cambro commented Nov 12, 2020

Ok, @iross given Ankur's description here, this needs to be explained/captured in some way via the documentation in the API. This is the line where there is seemingly a problem:
"type": "[Table, Figure, Equation, Body Text, Combined] - the type of object to search for.'''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to external interfaces with e.g. the COSMOS visualizer question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants