From 0b924dbaf60e4246ae272de264fbd497bcd90f69 Mon Sep 17 00:00:00 2001 From: Gregory Labute Date: Wed, 22 Nov 2023 16:07:01 -0500 Subject: [PATCH] add missing API doc --- .../Runtime/Deprecated/LegacyLensSettings.cs | 23 +++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/com.unity.cinemachine/Runtime/Deprecated/LegacyLensSettings.cs b/com.unity.cinemachine/Runtime/Deprecated/LegacyLensSettings.cs index 818003ea8..8615e77c1 100644 --- a/com.unity.cinemachine/Runtime/Deprecated/LegacyLensSettings.cs +++ b/com.unity.cinemachine/Runtime/Deprecated/LegacyLensSettings.cs @@ -9,25 +9,43 @@ namespace Unity.Cinemachine [Serializable] public struct LegacyLensSettings { + /// Obsolete. public float FieldOfView; + /// Obsolete. public float OrthographicSize; + /// Obsolete. public float NearClipPlane; + /// Obsolete. public float FarClipPlane; + /// Obsolete. public float Dutch; + /// Obsolete. public LensSettings.OverrideModes ModeOverride; + /// Obsolete. public Camera.GateFitMode GateFit; + /// Obsolete. [HideInInspector] public Vector2 m_SensorSize; + /// Obsolete. public Vector2 LensShift; + /// Obsolete. public float FocusDistance; + /// Obsolete. public int Iso; + /// Obsolete. public float ShutterSpeed; + /// Obsolete. public float Aperture; + /// Obsolete. public int BladeCount; + /// Obsolete. public Vector2 Curvature; + /// Obsolete. public float BarrelClipping; + /// Obsolete. public float Anamorphism; + /// Obsolete. public LensSettings ToLensSettings() { var lens = new LensSettings @@ -54,6 +72,7 @@ public LensSettings ToLensSettings() return lens; } + /// Obsolete public void SetFromLensSettings(LensSettings src) { FieldOfView = src.FieldOfView; @@ -76,7 +95,7 @@ public void SetFromLensSettings(LensSettings src) Anamorphism = src.PhysicalProperties.Anamorphism; } - /// Make sure lens settings are sane. Call this from OnValidate(). + /// Make sure legacy lens settings are sane. Call this from OnValidate(). public void Validate() { FarClipPlane = Mathf.Max(FarClipPlane, NearClipPlane + 0.001f); @@ -91,7 +110,7 @@ public void Validate() Anamorphism = Mathf.Clamp(Anamorphism, -1, 1); } - /// Default Lens Settings + /// Obsolete. Default Legacy Lens Settings public static LegacyLensSettings Default => new () { FieldOfView = 40f,