Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Center Crop error with Tensorflow #11

Open
hahahannes opened this issue Aug 2, 2021 · 5 comments
Open

Fix Center Crop error with Tensorflow #11

hahahannes opened this issue Aug 2, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@hahahannes
Copy link
Collaborator

The center cropping raises currently an Exception with Tensorflow backend and CNN transformations activated.
https://github.com/ViCCo-Group/THINGSvision/blob/master/thingsvision/model_class.py#L317

The crop width 224 should not be greater than input width.
Condition x >= 0 did not hold element-wise:
x (shape=() dtype=int32) = 
-221
@hahahannes hahahannes added the bug Something isn't working label Aug 2, 2021
@hahahannes hahahannes self-assigned this Aug 2, 2021
@LukasMut
Copy link
Collaborator

LukasMut commented Oct 9, 2022

@hahahannes is this still an open issue?

@LukasMut
Copy link
Collaborator

@hahahannes?

@hahahannes
Copy link
Collaborator Author

This was caused by this line: https://github.com/ViCCo-Group/THINGSvision/blob/4bbcb817333cc0e635b3b585e66717e99243721a/thingsvision/core/extraction/mixin.py#L147

But I am not sure whether this still raises an exception.

@LukasMut
Copy link
Collaborator

LukasMut commented Nov 1, 2022

@hahahannes could you please check whether this is still an issue?

@LukasMut
Copy link
Collaborator

@andropar, could you take over and see whether this is still an open issue, and if so how to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants