Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bad weather test cases for API client #76

Open
keithradford opened this issue Feb 4, 2021 · 0 comments
Open

Create bad weather test cases for API client #76

keithradford opened this issue Feb 4, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@keithradford
Copy link
Collaborator

As a developer, it would be nice if there were some bad weather test cases for the methods of the API client. As it stands, the test suite in src/__tests__/index.test.ts only test for when each method call succeeds and fetches data, however it would be good practice and beneficial if negative cases were tested.

Examples of this can be when the request to uvic.ca fails, when the parsed data is an unexpected form, etc.

These tests should be implemented in the existing test suite src/__tests__/index.test.ts where the existing good weather cases are.

@keithradford keithradford added the good first issue Good for newcomers label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant