Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Installed" tag not showing for wallets #54

Open
mooshee opened this issue Feb 29, 2024 · 1 comment
Open

"Installed" tag not showing for wallets #54

mooshee opened this issue Feb 29, 2024 · 1 comment
Labels
bug Something isn't working P2

Comments

@mooshee
Copy link

mooshee commented Feb 29, 2024

Describe the bug
The "INSTALLED" tag is normally shown in the wallet selector.

Here's the relevant code from WalletConnectModal

https://github.com/WalletConnect/WalletConnectSwiftV2/blob/3c8865674b95d86707b3d8687d4303af108ed350/Sources/WalletConnectModal/Modal/Screens/WalletList.swift#L223

SDK Version

  • Client: Swift
  • Version 1.1.0

To Reproduce
Steps to reproduce the behavior:

  1. Install a Wallet on your phone (e.g. MetaMask)
  2. Add the Wallet's url scheme to the Dapp's Info.plist under <key>LSApplicationQueriesSchemes</key>
  3. Present the Web3Modal Web3Modal.present()

Expected behavior
The "Connect wallet" list should show the "INSTALLED" tag next to the wallet

Screenshots
I have MetaMask, Rainbow, and Coinbase installed and each of their url schemes set in my plist.

IMG_9269

@mooshee mooshee added the bug Something isn't working label Feb 29, 2024
@mooshee
Copy link
Author

mooshee commented Feb 29, 2024

I suppose this could be considered a feature since it's not implemented. I consider it a bug because the latest documentation says it should work.

@bkrem bkrem added P3 P2 and removed P3 labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2
Projects
None yet
Development

No branches or pull requests

2 participants