Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify overly complex project internals #27

Open
pavelhoral opened this issue Aug 17, 2022 · 0 comments
Open

Simplify overly complex project internals #27

pavelhoral opened this issue Aug 17, 2022 · 0 comments

Comments

@pavelhoral
Copy link
Member

pavelhoral commented Aug 17, 2022

I have spent quite a lot of time working on this project. I was hesitant to create this issue because I felt like I am lacking a lot of know-how to propose such a significant change. However....

  • version 1.5 introduced protobuf
  • version 1.5 introduced websocket as transport
  • version 1.5 abstracted RPC mechanics (request / response / response stream) as an unbelievably super generic abstract thing

I think it is apparent which part of the framework I consider in need of rewrite :). The generics in framework-rpc module makes working with the project so so so so so so much harder (both in terms of understanding what is going on and in terms of source code littered with unnecessary generic parameters).

I am creating this issue to start discussion (or maybe direct efforts) on how to rewrite this part of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant