Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs build-essential #65

Open
mossplains opened this issue Aug 7, 2022 · 3 comments
Open

Needs build-essential #65

mossplains opened this issue Aug 7, 2022 · 3 comments

Comments

@mossplains
Copy link

Please specify in the compilation instructions in the readme that build-essential is needed for cmake to work. It's the one piece I was missing and kept getting errors without it. I'm on Ubuntu 22.04.

@ExoSkye
Copy link

ExoSkye commented Aug 7, 2022

Well as the name suggests, I think it'd be implied that you'd need that on Debian based systems. Also the current list of required packages should work on all major operating systems, whilst build-essential is Debian only, causing other people to have issues with installing the dependencies on distros such as Arch which don't have a build-essential package (Arch has base-devel instead)

@JayFoxRox
Copy link
Member

The instructions should be changed, so instead of gcc, a working C compiler is expected (which would include build-essential or base-devel... or whatever your platform requires).
What is required for each compiler and how it is shipped will depend on your target platform.
We should avoid platform specific install instructions for such a simple CLI app.

Other than that, the code should be somewhat portable (it actually isn't, see #29 - which is also pinned).
Looks like there's no gcc specific attributes or pragmas yet (why? shouldn't this be using packed structs?).

@mossplains
Copy link
Author

Since no binary is being provided for Linux and the installation instructions are to compile yourself, I should hope that you would make it beginner-friendly enough by providing the complete instructions one what one needs to do on a fresh install of an OS in order to compile the app. I'm a programmer, but I completely forgot about build-essential and I'm on a fresh install that I haven't used for programming, so I was mystified as to why cmake wasn't working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants