Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xboxpy/interface/dbg_pb2.py ought to be generated #22

Open
dracc opened this issue Aug 4, 2018 · 1 comment
Open

xboxpy/interface/dbg_pb2.py ought to be generated #22

dracc opened this issue Aug 4, 2018 · 1 comment

Comments

@dracc
Copy link

dracc commented Aug 4, 2018

The current supplied version of dbg_pb2.py did not work (at least for me), but supplying my own generated one from running make in nxdk-rdt works fine.

JayFoxRox: so the proposed fix / test is to generate dbg_pb2.py using your protobuf [as was done during make for nxdk-rdt] and then copy it into your xboxpy installation
@JayFoxRox
Copy link
Member

We should probably specify the required version of protobuf so we can ship outdated dbg_pb2.py. Alternatively we should check how protobuf stuff wants to be distributed.

Just updating dbg_pb2.py sounds like a bad idea to me (although it is a workaround).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JayFoxRox @dracc