Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packagegroup-petalinux-ros doesn't actually include ros2-control #28

Open
msandstedt opened this issue Aug 16, 2023 · 1 comment
Open

Comments

@msandstedt
Copy link

See above. This is duplicatively pulling in demos, not ros2-control. Nominally, this would be the fix:

diff --git a/recipes-core/packagegroups/packagegroup-petalinux-ros.bb b/recipes-core/packagegroups/packagegroup-petalinux-ros.bb
index c97813d..b6b15bf 100644
--- a/recipes-core/packagegroups/packagegroup-petalinux-ros.bb
+++ b/recipes-core/packagegroups/packagegroup-petalinux-ros.bb
@@ -148,7 +148,7 @@ RDEPENDS:${PN}-demo:aarch64 = "\
 "
 
 RDEPENDS:${PN}-control:aarch64 = "\
-    ${ROS_DEMO_PACKAGES} \
+    ${ROS_CONTROL_PACKAGES} \
 "
 
 RDEPENDS:${PN}-dev:aarch64 = "\

However, if one is to actually attempt to build the ROS_CONTROL_PACKAGES recipes, the build will fail. Those recipes are these:

SUMMARY:${PN}-control = "ROS_CONTROL_PACKAGES includes ROS control packages"
ROS_CONTROL_PACKAGES = "\
    controller-interface \
    controller-manager \
    controller-manager-msgs \
    hardware-interface \
    ros2-control \
    ros2controlcli \
    ros2-control-test-assets \
    transmission-interface \
"

When I check what content is included for meta-ros from petalinux 2022.2, it is very close to this: https://github.com/ros/meta-ros/tree/honister

So I think the problem is two-fold:

  • packagegroup-petalinux-ros purports to pull in ros2-control, but doesn't actually do so; hence there is no CI coverage or visibility into those recipes failing
  • AND those recipes do fail to build, as they seem to be broken in meta-ros:honister.
@grsandeep85
Copy link
Contributor

grsandeep85 commented Aug 16, 2023

Hi @msandstedt ,

We have fixed this issue back in April 2023 but looks like patch is not published to 2022.2 and 2023.1 release we will push the patch in a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants