You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that you have individual codes for Scotland, England, Wales and Northern Ireland, which is nice, but the overall "United Kingdom of Great Britain and Northern Ireland" country code you're using is GB-UKM or rather the overall code for GB doesn't seem to be supported as listed under ISO 3166-1 alpha-2, see here: https://www.iban.com/country-codes
Please check all that apply
visual bug
functional bug
able to consistently reproduce
Expected Behavior
Using GB as the country code should result in the United Kingdom of Great Britain and Northern Ireland flag to be shown.
Current Behavior
Currently, using GB-UKM is the closest match.
Possible Solution
Change the country code to reflect the ISO standard.
Using GBR-UKM and it's variants were our solution to both support the flag for United Kingdom aswell as England, Scotland, Wales and Northern Ireland. These are part of the ISO 3166 subset, ISO 3166-2:GB which we are planning to continue to support in our release of Flagpack. However I do concede that given our ISO 3166 policy we should definitely support both the ISO 3166 alongside the 3166-2:GB to cover all bases. This is especially true now that we're working on having Flagpack treeshakable. You can expect these changes to be part of the next major release of Flagpack.
It seems that you have individual codes for Scotland, England, Wales and Northern Ireland, which is nice, but the overall "United Kingdom of Great Britain and Northern Ireland" country code you're using is
GB-UKM
or rather the overall code forGB
doesn't seem to be supported as listed under ISO 3166-1 alpha-2, see here: https://www.iban.com/country-codesPlease check all that apply
Expected Behavior
Using
GB
as the country code should result in the United Kingdom of Great Britain and Northern Ireland flag to be shown.Current Behavior
Currently, using
GB-UKM
is the closest match.Possible Solution
Change the country code to reflect the ISO standard.
Steps to Reproduce
1 Go here: https://flagpack.xyz/docs/flag-index/
2 Search for GB
3 Find
GB-*
instead ofGB
.Context
I'm getting the country codes from a database according to the ISO standard. Therefore a specific hack for GB isn't something that I'd want to add.
Your Environment
The text was updated successfully, but these errors were encountered: