-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MARTIAN, VENUSIAN, WATER, and ICE planets do not have atmospheres. #1
Comments
What you have to remember about star gen is that the calculations are based on the best guess of how our solar system is formed in the 60s |
The star gen codeline is an imperfect copy of the research done at the time, and it applies the earthlike atmosphere step too widely to the rocky planets because the paper it came from didn't properly detail the logic |
That's fair -- do you have any details on more recent thinking on atmosphere formation (or more modern papers on solar system formation in general)? I'm well aware that as written StarGen does some wacky things around atmospheres -- the biggest one I initially flagged for myself was that it doesn't alter the boiling / freezing points of gases with pressure, but I'm well aware that it's approach is massively simplistic. I'm hoping I can incrementally improve it rather than starting from scratch. |
Avivah Yamani and her team are the only researchers playing around with the code base recently. They are on my list to document and may have something directly useful. Other than that Google scholar is unfortunately your best bet. |
They definitely have formula to improve the collision conditions anyway |
I think this is an issue in StarGen too, but from our own solar system, we can expect that all except maybe ICE planets should have some atmospheres.
The most glaring exception is VENUSIAN which should definitely have a massive atmosphere.
The text was updated successfully, but these errors were encountered: