Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARTIAN, VENUSIAN, WATER, and ICE planets do not have atmospheres. #1

Open
Zomega opened this issue May 9, 2018 · 5 comments
Open

Comments

@Zomega
Copy link
Owner

Zomega commented May 9, 2018

I think this is an issue in StarGen too, but from our own solar system, we can expect that all except maybe ICE planets should have some atmospheres.

The most glaring exception is VENUSIAN which should definitely have a massive atmosphere.

@zakski
Copy link

zakski commented May 9, 2018

What you have to remember about star gen is that the calculations are based on the best guess of how our solar system is formed in the 60s

@zakski
Copy link

zakski commented May 9, 2018

The star gen codeline is an imperfect copy of the research done at the time, and it applies the earthlike atmosphere step too widely to the rocky planets because the paper it came from didn't properly detail the logic

@Zomega
Copy link
Owner Author

Zomega commented May 9, 2018

That's fair -- do you have any details on more recent thinking on atmosphere formation (or more modern papers on solar system formation in general)?

I'm well aware that as written StarGen does some wacky things around atmospheres -- the biggest one I initially flagged for myself was that it doesn't alter the boiling / freezing points of gases with pressure, but I'm well aware that it's approach is massively simplistic. I'm hoping I can incrementally improve it rather than starting from scratch.

@zakski
Copy link

zakski commented May 10, 2018

Avivah Yamani and her team are the only researchers playing around with the code base recently. They are on my list to document and may have something directly useful. Other than that Google scholar is unfortunately your best bet.

@zakski
Copy link

zakski commented May 10, 2018

They definitely have formula to improve the collision conditions anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@Zomega @zakski and others