Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aave alarm integration #1767

Open
nebolax opened this issue Sep 1, 2023 · 7 comments
Open

Aave alarm integration #1767

nebolax opened this issue Sep 1, 2023 · 7 comments
Labels
feature New feature or request new issue This issue has not been triaged by the core team yet

Comments

@nebolax
Copy link

nebolax commented Sep 1, 2023

Currently on the aave interface there is a button to set up notifications with Hal project.

image

That's obviously great! But I've also made an aave-specific mobile app where you can track your addresses and receive notifications in case your health factor gets too low or you get liquidated and I think it will make sense to mention this mobile app on the website too. App repo: https://github.com/nebolax/aavealarm (it was developed thanks to a grant from aave grants dao!).

So, I am proposing an addition of some sort of a link to google play & app store on the website.

@nebolax nebolax added feature New feature or request new issue This issue has not been triaged by the core team yet labels Sep 1, 2023
@NandyBa
Copy link
Contributor

NandyBa commented Sep 16, 2023

Assuming HAL temperature check for integration on the Aave UI good practice can be to do a similar vote.

@NandyBa
Copy link
Contributor

NandyBa commented Sep 16, 2023

@nebolax to you have Aave Alarm grey logo and hover logo as svg as public/icons/healthFactor/HAL.svg public/icons/healthFactor/HALHover.svg ?

NandyBa added a commit to NandyBa/Aave-interface that referenced this issue Sep 16, 2023
@nebolax
Copy link
Author

nebolax commented Sep 16, 2023

@nebolax to you have Aave Alarm grey logo and hover logo as svg as public/icons/healthFactor/HAL.svg public/icons/healthFactor/HALHover.svg ?

Probably not. I need to create one for the proposal, right?

@NandyBa
Copy link
Contributor

NandyBa commented Sep 16, 2023

@nebolax to you have Aave Alarm grey logo and hover logo as svg as public/icons/healthFactor/HAL.svg public/icons/healthFactor/HALHover.svg ?

Probably not. I need to create one for the proposal, right?

No it's just for integration :) to prepare UI component as curent HAL one.

Enregistrement.de.l.ecran.2023-09-16.a.22.24.58.mov

@NandyBa
Copy link
Contributor

NandyBa commented Sep 16, 2023

@nebolax I let you submit the proposal you are more legit to do it.

NandyBa added a commit to NandyBa/Aave-interface that referenced this issue Sep 16, 2023
NandyBa added a commit to NandyBa/Aave-interface that referenced this issue Sep 16, 2023
NandyBa added a commit to NandyBa/Aave-interface that referenced this issue Sep 16, 2023
@NandyBa
Copy link
Contributor

NandyBa commented Sep 16, 2023

Feel free to give me your feedback. If you want to test the composant you can do it by checking this branch feat/1767-add-aave-alarm-app-links

Enregistrement.de.l.ecran.2023-09-17.a.00.04.11.mov

Note: icon will be change to your's when given.

@nebolax
Copy link
Author

nebolax commented Sep 16, 2023

Sure!! Will definitely check it out.

(but looks already great!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request new issue This issue has not been triaged by the core team yet
Projects
None yet
Development

No branches or pull requests

2 participants