Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Pool approval amounts #1800

Open
defispartan opened this issue Oct 3, 2023 · 1 comment
Open

Standardize Pool approval amounts #1800

defispartan opened this issue Oct 3, 2023 · 1 comment
Labels
feature New feature or request new issue This issue has not been triaged by the core team yet

Comments

@defispartan
Copy link
Collaborator

supply, repay, repayWithPermit, and supplyWithPermit are all approving underlying tokens to the Pool contract. Some approvals use a max approval while others use per-tx allowance. This should be standardized or give the option to select max approval vs per-tx.

@defispartan defispartan added feature New feature or request new issue This issue has not been triaged by the core team yet labels Oct 3, 2023
@defispartan defispartan changed the title Standardize approval amounts Standardize Pool approval amounts Oct 3, 2023
@JoaquinBattilana
Copy link
Member

Hey just to add some context to this, there are some cases that we absolutely need max approval, for example for repayWithPermit if you want to do a max repay you need to pass a signature with max approval because it validates it in the contracts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request new issue This issue has not been triaged by the core team yet
Projects
None yet
Development

No branches or pull requests

2 participants