Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: AccountsJS + Oauth + Packages + Docs #1031

Closed
4 of 11 tasks
agustif opened this issue Aug 1, 2020 · 2 comments
Closed
4 of 11 tasks

RFC: AccountsJS + Oauth + Packages + Docs #1031

agustif opened this issue Aug 1, 2020 · 2 comments

Comments

@agustif
Copy link
Contributor

agustif commented Aug 1, 2020

@nsine was kind enough to share his work implementing Google oauth with Accounts on #961
Also related to: #1026 #875

I want to continue @nsine's work in order to complete as much as possible the AccountsJS oauth ecosystem and docs.

This PR adds very rough example of how to use accounts-js OAuth to login/register with Google.
Opening it (as a draft, as don't have too much time atm to polish it) mostly because @agustif asked some help on this and may be can be useful for others.

Feel free to pick this up and implement complete example if someone has time/motivation. This can serve as a good base to start from 🙂.
What has to be done from my PoV to add this as an official example:

  • make nice styling
  • Add other examples apart from google (e.g. OOTB twitter, instagram)
  • Add error handling
  • Add some readme to oauth package and reference
  • Add page where we can link oauth providers to existing accounts (afaik @agustif already tried to do sth like this)

To make this work:

  • fill examples/react-rest-typescript/.env.development with valid google client id and callback url
  • create .env file in examples/rest-express-typescript folder with variables from .env.example in same folder

Hope that helps!

Oauth adapters

  • Instagram (Already on packages)
  • Twitter (Already on packages)
  • Google by @nsine
  • Facebook by @agustif
  • NextCloud by @tennox
  • GitHub

Oauth example

@nsine extended the rest examples, should I continue this and push to the rest examples adding oauth, or fork with a new example folders for oauth cllient and server?

Also planning on doing GraphQL too, I think @nsine uses it and can help me if needed!

Please comment!

This is a request for comments, so any feedback idea will be greatly appreciated.

@pradel
Copy link
Member

pradel commented Aug 3, 2020

@agustif I think that adding it to the current rest example is the easiest way for now :)

tennox added a commit to tennox/accounts that referenced this issue Dec 9, 2020
@tennox
Copy link
Contributor

tennox commented Dec 9, 2020

@agustif @nsine Ready for review: #1080

😎

@agustif agustif closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants