Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ADMIN accessType usage from tests that have lower-level access types #285

Open
shravanhariharan2 opened this issue Feb 7, 2022 · 0 comments
Labels

Comments

@shravanhariharan2
Copy link
Collaborator

Currently, many tests use an admin user to test if specific functionality works for users of higher privilege, but that are not necessarily admins.

For example, in this test: https://github.com/acmucsd/membership-portal/blob/master/tests/merchStore.test.ts#L162 , we are testing that only admins can edit merch collections. But since store managers also have edit permissions on merch collections, we should be create fake users that assume the STORE_MANAGER role vs. the ADMIN role, since presumably, the admin role has access to anything that a higher privileged user has access to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant