Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Refactor #429

Open
nik-dange opened this issue Apr 4, 2024 · 0 comments
Open

Feedback Refactor #429

nik-dange opened this issue Apr 4, 2024 · 0 comments
Assignees

Comments

@nik-dange
Copy link
Member

nik-dange commented Apr 4, 2024

While we have a working feedback implementation right now, we should refactor it to be more consistent with the codebase, scalable, and more aligned with how frontend might use it.

As such, we need four routes:

Users posting feedback:
POST /feedback

Admins being able to see all feedback associated with an event (restricted route):
GET /event/uuid/feedback

Get user feedback for event uuid, regardless of role:
GET /feedback/event/uuid

Acknowledge/ignore feedback:
PATCH /feedback/uuid

The current implementations of the POST and PATCH routes shouldn't need to be changed. However, we should get rid of the query parameters structure and go with more straightforward queries.

Here's a quick diagram that might clarify things:
IMG_9889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants