Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Conversion: Custom Icons to Standard Icons #303

Closed
2 tasks done
otaree opened this issue Aug 26, 2023 · 7 comments
Closed
2 tasks done

Icon Conversion: Custom Icons to Standard Icons #303

otaree opened this issue Aug 26, 2023 · 7 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@otaree
Copy link
Contributor

otaree commented Aug 26, 2023

Terms

Description

This issue focuses on optimizing icon usage within the project by transitioning from custom icon components to standard icons. The aim is to enhance consistency and maintenance. The suggestion involves incorporating standard icons like or Bootstrap Icons for non-branded situations.

Contribution

Happy to support someone on this issue or work on it myself

@otaree otaree added the feature New feature or request label Aug 26, 2023
@andrewtavis andrewtavis added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 26, 2023
@andrewtavis
Copy link
Member

Thank you, @otaree! Let's finish up #299 and then if you'd like to start on this one we can look into where the changes need to happen 😊

@andrewtavis
Copy link
Member

Just assigned you given our discussion in #299, @otaree!

@andrewtavis
Copy link
Member

Looking at the current custom icons, @otaree, I think we have viable options for a few of them:

The other ones I didn't find very good options for, or they're branded :) Note further that we'd need to make sure that the licenses for them are included in NOTICE.txt. I can do this and also check to make sure that we have all icons included in there so far 😊

@otaree otaree mentioned this issue Aug 27, 2023
1 task
@otaree
Copy link
Contributor Author

otaree commented Aug 27, 2023

I've found some possible replacements for our custom icons:

  1. IconOrganization: https://icones.js.org/collection/all?s=group
  2. IconFAQ: https://icones.js.org/collection/all?s=question
  3. IconResource: https://icones.js.org/collection/all?s=wrench

Please let me know your thoughts on these icon choices. If they align well with our design and messaging, we could potentially use them to replace our current custom icons. Looking forward to your feedback!

@andrewtavis
Copy link
Member

I was looking for some of those as well, @otaree :) Thanks for checking for them too! Thing is that for each of them there's not really a good option that fully replaces what the current one does. For organizations there's none that has people in a rounded square; for faqs none with a question in a talk bubble; and for resources there's none that also includes a pencil, as some resources would be written (especially at the start). I think we're fine with the current shifts in this 😊

I'll get to the review shortly!

@andrewtavis
Copy link
Member

The FAQ one that we have is a combination of some things from our main one, bootstrap. I'm seeing now that there are a couple that are in chat bubbles, but they're just not quite right as far as not having rounded corners for the question mark dot or just looking a bit weird 🤔

otaree added a commit to otaree/activist that referenced this issue Aug 28, 2023
… in affected components: IconLegal, IconDiscussion
andrewtavis added a commit that referenced this issue Aug 29, 2023
#303 | Replaced custom icons with standard icons, updated in affected components: IconLegal, IconDiscussion
@andrewtavis
Copy link
Member

218d3a8 finalizes this, @otaree :) I actually reverted back to the legal icon as I just didn't like how the others were looking. Plus when I looked at the designs I remembered that I actually made this icon myself 😇 I also expanded out the NOTICE.txt file with all of the needed licenses from the icon sets, so it's great that we got to this! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants