Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Workflow for eslint #446

Closed
2 tasks done
to-sta opened this issue Oct 13, 2023 · 2 comments
Closed
2 tasks done

GitHub Workflow for eslint #446

to-sta opened this issue Oct 13, 2023 · 2 comments
Assignees
@to-sta
Labels
feature New feature or request

Comments

@to-sta
Copy link
Collaborator

to-sta commented Oct 13, 2023

Terms

Description

General:
On the backend side of things we have the whole suite already: formatter, linter and static type checking. It is also configured to work well together.

On the frontend side we are still missing the linter.

The task is to add an eslint step to the pr_ci_frontend workflow. In case this or any other step fails in the workflow it should continue to run.

Prerequisite is the merge of PR #444 and solving the issue #445

Contribution

I am happy to help someone or work on this myself :smile
@to-sta to-sta added the feature New feature or request label Oct 13, 2023
@to-sta
Copy link
Collaborator Author

to-sta commented Oct 14, 2023

I added another issue #449 about configuring eslint. This should be resolved before we start merging a PR with a new workflow.

@to-sta to-sta mentioned this issue Oct 16, 2023
Merged
1 task
@andrewtavis
Copy link
Member

Closed by #466 🚀 Let me know if you think anything else is needed as far as workflows, @to-sta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@to-sta to-sta

Labels
feature New feature or request
Projects
activist Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtavis @to-sta