Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 #80

Closed
derunterstrich opened this issue Jan 30, 2023 · 5 comments · Fixed by #82
Closed

PHP 8.1 #80

derunterstrich opened this issue Jan 30, 2023 · 5 comments · Fixed by #82

Comments

@derunterstrich
Copy link

Hello,

Since PHP 7.4 is already EOL, I wanted to update my application to PHP 8.1. Unfortunately, it does not work because the compsoer "php" defaults to "^7.1".

Problem 1
- Root composer.json requires adrenalinkin/swagger-resolver-bundle ^0.4.6 -> satisfiable by adrenalinkin/swagger-resolver-bundle[v0.4.6].
- adrenalinkin/swagger-resolver-bundle v0.4.6 requires php ~7.1 -> your php version (8.1.13) does not satisfy that requirement.

Is an update planned here, or do I have to look for something new?

@mario-fehr
Copy link
Contributor

mario-fehr commented Jan 30, 2023

In present time I working on finishing coverage for this bundle. Аurther according to plan is improvements and fixes. And all of that will be a first stable release. First stable release should compatible with Symfony 3.4, so please don't try to remove compatibility in this issue

Originally posted by @adrenalinkin in #72 (comment)

@adrenalinkin
Copy link
Owner

Hello guys! this project already covered by tests but i was want to add more improvement before release first version of the package.

Anyway I think it would be better if you add support for php 8.1 I think we can start 2.0 branch where you can drop compatibilities with old version of php and symfony

And i reserve version 1.0 for old versions.

What are you thinking about this?

@mario-fehr
Copy link
Contributor

@adrenalinkin sound good to me

@adrenalinkin
Copy link
Owner

@derunterstrich Hello! You can use 1.0.0 release to work with php 8

@derunterstrich
Copy link
Author

big thx! it works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants