Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

before deleting the client we should do a get #4

Open
maleck13 opened this issue Feb 20, 2018 · 2 comments
Open

before deleting the client we should do a get #4

maleck13 opened this issue Feb 20, 2018 · 2 comments

Comments

@maleck13
Copy link
Contributor

It is possible for the client representation to be removed without invoking this APB, so we should be more defensive and perform a get client and check it is present before performing the delete, . If it is not present we can simply exit with an ok status

@JameelB ping WDYT ?

@JameelB
Copy link
Contributor

JameelB commented Feb 20, 2018

@maleck13 I think this would be great. Is it also possible to ensure that all other configurations that might've been created or left over, like secrets, are removed?

@maleck13
Copy link
Contributor Author

The mobile client apbs don't create any additional resources. So I think it would be out of their scope to try and manage things that they hadn't created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants