From 090866a80a7b10676928d11be9798ee82b17bd66 Mon Sep 17 00:00:00 2001
From: Andrus Adamchik <andrus@objectstyle.com>
Date: Tue, 9 Jul 2024 17:37:50 -0400
Subject: [PATCH] comments on potential flakiness

---
 .../processor/select/ViaQueryWithParentExpResolver.java      | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/agrest-cayenne/src/main/java/io/agrest/cayenne/processor/select/ViaQueryWithParentExpResolver.java b/agrest-cayenne/src/main/java/io/agrest/cayenne/processor/select/ViaQueryWithParentExpResolver.java
index 8a5b82c9a..62da31c07 100644
--- a/agrest-cayenne/src/main/java/io/agrest/cayenne/processor/select/ViaQueryWithParentExpResolver.java
+++ b/agrest-cayenne/src/main/java/io/agrest/cayenne/processor/select/ViaQueryWithParentExpResolver.java
@@ -84,6 +84,11 @@ public DataReader dataReader(RelatedResourceEntity<T> entity, ProcessingContext<
 
     protected void indexResultByParentId(RelatedResourceEntity<T> entity, List<Object[]> result) {
 
+        // implicit ID ordering ... It must match that of CayenneQueryAssembler.queryColumns, or the values will
+        // be assigned to the wrong columns.
+
+        // TODO: be extra paranoid and sort the key columns in both places?
+
         AgIdPart[] idAttributes = entity.getParent().getAgEntity().getIdParts().toArray(new AgIdPart[0]);
 
         for (Object[] row : result) {