Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm private repos aren't working #226

Open
Brightside56 opened this issue Dec 12, 2023 · 4 comments
Open

helm private repos aren't working #226

Brightside56 opened this issue Dec 12, 2023 · 4 comments

Comments

@Brightside56
Copy link

Brightside56 commented Dec 12, 2023

With fresh versions of kargo-render (which started to use ArgoCD repo server for rendering helm) - helm private repos aren't working anymore (kargo credentials same as ArgoCD credentials borrowing). To make it working with repo server - kargo-render should most probably pass credentials and allowed sources here

res, err := repository.GenerateManifests(
as part of ManifestRequest object, otherwise repo server doesn't know which credentials to use or where to get them

@krancour
Copy link
Member

krancour commented Jan 3, 2024

@Brightside56 the changes from #201 were released today in v0.1.0-rc.34.

Did those improvements somehow fix this for you in a way I wasn't anticipating?

@Brightside56
Copy link
Author

@krancour oops, sorry, I'll re-open it, those changes make helm working again generally, but not private repos

@Brightside56 Brightside56 reopened this Jan 3, 2024
@krancour
Copy link
Member

krancour commented Jan 3, 2024

Thanks @Brightside56. I sensed this may have been closed in error. Glad I checked.

@krancour
Copy link
Member

Kargo proper recently did something about this in akuity/kargo#1977

It does a helm login for each repo referenced in a subchart (if matching credentials are found) prior to doing things like helm chart build.

We could take a similar approach here and do helm login for each of n provided chart repo credentials before delegating rendering to the repo server.

This leaves the main question as one of how to pass multiple helm chart repo credentials to kargo render securely without it being a terrible UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants