Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental::Accessor #1897

Closed
1 task done
bernhardmgruber opened this issue Jan 9, 2023 · 0 comments · Fixed by #2054
Closed
1 task done

Remove experimental::Accessor #1897

bernhardmgruber opened this issue Jan 9, 2023 · 0 comments · Fixed by #2054

Comments

@bernhardmgruber
Copy link
Member

bernhardmgruber commented Jan 9, 2023

We added alpaka::experimental::Accessor and some related classes to support SYCL as a backend for SYCL versions without pointers to device memory on the host (USM). Since #1482 was merged, this functionality can just as well be provided by std::mdspan. Furthermore, work is currently ongoing on reengineering the SYCL backend to require USM and thus also make alpaka::experimental::Accessor obsolete. See #1845.

Depending on whether USM will be required for the SYCL backend, we may need to add specializations for alpaka::GetMdspan to create mdspans from SYCL buffers/accessors, or it may just work out of the box with USM pointers. In both cases, alpaka::experimental::Accessor is no longer required.

I would suggest we wait for the USM reengineering to finish and then remove alpaka::experimental::Accessor.

Depends on:

@bernhardmgruber bernhardmgruber self-assigned this Jan 9, 2023
bernhardmgruber added a commit to bernhardmgruber/alpaka that referenced this issue Aug 2, 2023
bernhardmgruber added a commit to bernhardmgruber/alpaka that referenced this issue Aug 3, 2023
bernhardmgruber added a commit to bernhardmgruber/alpaka that referenced this issue Aug 3, 2023
bernhardmgruber added a commit to bernhardmgruber/alpaka that referenced this issue Aug 3, 2023
bernhardmgruber added a commit that referenced this issue Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant