Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Sentence Encoder tests occasionally crash #1

Open
ctduffy opened this issue Aug 14, 2019 · 1 comment
Open

Universal Sentence Encoder tests occasionally crash #1

ctduffy opened this issue Aug 14, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@ctduffy
Copy link
Contributor

ctduffy commented Aug 14, 2019

The testing for the universal sentence encoder takes up too much memory, so fails due to being 'killed' on circleci. So, since it passes locally in the same virtualenv setup as circleci, it has been commented out at present. Furthermore, either of the two universal sentence encoder tests can pass in circle ci, just not both at the same time, which further points to the fact that it is a memory usage issue rather than a correctness one.

@dsherry dsherry added the bug Something isn't working label Oct 22, 2020
@dsherry
Copy link
Contributor

dsherry commented Oct 22, 2020

I've been noticing this too lately.

nlp_primitives/tests/test_universal_sentence_encoder.py::test_regular PASSED [ 87%]
nlp_primitives/tests/test_universal_sentence_encoder.py::test_without_tensorflow PASSED [ 88%]
nlp_primitives/tests/test_universal_sentence_encoder.py::test_primitive_serialization PASSED [ 90%]
nlp_primitives/tests/test_universal_sentence_encoder.py::test_feature_serialization make: *** [Makefile:29: unit-tests] Killed

@dsherry dsherry changed the title Universal Sentence Encoder Testing takes up too much memory Universal Sentence Encoder tests occasionally crash Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants