Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential data leakage due to some features? #27

Open
coderaing opened this issue Jul 6, 2023 · 0 comments
Open

Potential data leakage due to some features? #27

coderaing opened this issue Jul 6, 2023 · 0 comments

Comments

@coderaing
Copy link

coderaing commented Jul 6, 2023

Firstly, thanks for the detailed notebooks! Learnt a lot from it.

In https://github.com/Featuretools/predict-customer-churn/blob/main/churn/3.%20Feature%20Engineering.ipynb,
I assume that the features num_25, num_50, num_75, num_985, num_100, and num_unq, etc represent the number of specific types of transactions (e.g., number of songs played with 25% completion, 50% completion, etc.) for each customer.

Wouldnt using these features (and various transformations/aggregations on it) in the windows lead to data leakage?

Because basically we are using the information from the future or outside the given time window to create features or train a model.

I have a similar use-case where we have few customer columns like ltv, nr_orders etc which reflect value "as of today". I am not sure how to handle these in the windows that are created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant