Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ctrl-g for abort impossible #255

Closed
TLINDEN opened this issue Sep 23, 2024 · 3 comments
Closed

Setting ctrl-g for abort impossible #255

TLINDEN opened this issue Sep 23, 2024 · 3 comments

Comments

@TLINDEN
Copy link

TLINDEN commented Sep 23, 2024

I tried to configure C-g as the abort key instead of q because I am used to it.

This is the setting:

[bindings]
root.quit = ["ctrl+g", "<esc>"]

However, when I start gitu with this setting, abortion of anything including gitu itself is impossible. It seems to regard the binding as q doesn't work anymore, but it doesn't respond to C-g either.

Would be really nice if that could work.

While we're at it: maybe you consider adding C-c as some kind of fallback binding as well?

@altsem
Copy link
Owner

altsem commented Sep 24, 2024

@TLINDEN I think there's multiple things going wrong here 😅

There are some things you could fix/workaround:

  • The syntax should be root.quit = ["<ctrl+c>", "<ctrl+g>", "<esc>"]
  • You may want to add these to each individual menu
    rebase_menu.quit = ["<ctrl+c>", "<ctrl+g>", "<esc>"]
    reset_menu.quit = ["<ctrl+c>", "<ctrl+g>", "<esc>"]
    ...
    

I think there are improvements to be made to Gitu regarding:

@TLINDEN
Copy link
Author

TLINDEN commented Sep 25, 2024

  • The syntax should be root.quit = ["<ctrl+c>", "<ctrl+g>", "<esc>"]

Ah, this works like a charm, very nice :)

@altsem
Copy link
Owner

altsem commented Sep 25, 2024

👍 I'll close this. The other issues will address the usability!

@altsem altsem closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants