Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define TMC5272_MSLUT_START_OFFSET_SIN90_FIELD wrongly defines the field value as unsigned. #56

Open
chrislro2019 opened this issue Apr 12, 2024 · 0 comments

Comments

@chrislro2019
Copy link

https://github.com/analogdevicesinc/TMC-API/blob/f276b3e94894494009a1c44e3eb21512ad0ab320/tmc/ic/TMC5272/TMC5272_HW_Abstraction.h#L295C1-L295C196

// is
#define TMC5272_MSLUT_START_OFFSET_SIN90_FIELD                ((RegisterField) { TMC5272_MSLUT_START_OFFSET_SIN90_MASK,  TMC5272_MSLUT_START_OFFSET_SIN90_SHIFT,  TMC5272_MSLUT_SEL_START, false })
// should be signed according to datasheet ("Signed offset for CUR_B ±127 microsteps")
#define TMC5272_MSLUT_START_OFFSET_SIN90_FIELD                ((RegisterField) { TMC5272_MSLUT_START_OFFSET_SIN90_MASK,  TMC5272_MSLUT_START_OFFSET_SIN90_SHIFT,  TMC5272_MSLUT_SEL_START, true })
@chrislro2019 chrislro2019 changed the title TMC5272_MSLUT_START_OFFSET_SIN90_FIELD wrongly defines the field value as unsigned. #define TMC5272_MSLUT_START_OFFSET_SIN90_FIELD wrongly defines the field value as unsigned. Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant