Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New element: SeriesSort #4

Open
gotson opened this issue Jan 9, 2022 · 13 comments
Open

New element: SeriesSort #4

gotson opened this issue Jan 9, 2022 · 13 comments
Labels
non-breaking The change will generate a new minor version of the schema RFC Request for comments

Comments

@gotson
Copy link
Member

gotson commented Jan 9, 2022

Where does this comes from?

Discussions on Mylar's Discord.

What is the rationale for adding support for this element?

The current Title Series cannot provide a proper sort order for series with a leading article. In English language those would be A, An, or The.

Having this field would remove may potential guess work in the consuming applications. The different languages of the publications also make the task harder, as each and every language has different rules for handling articles.

Is the element already handled by any application or tool?

No, but Mylar already computes a sortname by removing The from the series name.

Komga already has a field for sort title too, and could import this if it exists.

@gotson gotson added non-breaking The change will generate a new minor version of the schema RFC Request for comments labels Jan 9, 2022
@gotson
Copy link
Member Author

gotson commented Jan 20, 2022

@majora2007 what do you think about this one? Does Kavita has a sort title field?

@majora2007
Copy link

We do, I will add support for this as well. Feel free to merge it.

@majora2007
Copy link

How does this work? Does it apply only to individual issues or does it aggregate up to the Series if they are all the same?

@gotson
Copy link
Member Author

gotson commented Jan 21, 2022

How does this work? Does it apply only to individual issues or does it aggregate up to the Series if they are all the same?

This is related to the existing Title Series element, which represents the name of the series.

What Komga does at the moment is this:

The Series and Volume tags will be used to overwrite the title of the Series, in the form <Series> (<Volume>), or just <Series> if the Volume tag is not present or if the Volume is 1. If multiple values are present, the most frequent value from all books will be used.

But of course it depends on the consuming application's data model. Komga doesn't store the series name at book level, but only at the upper level (the series object). Other applications could deal with this differently.

I would suggest that consuming applications should treat this in the same way they treat the Title Series element.

@gotson
Copy link
Member Author

gotson commented Jan 21, 2022

@evilhero is that something that could make its way in mylar? Since you already have a sort name without the?

@lordwelch
Copy link
Contributor

lordwelch commented Jan 21, 2022

I think it might be better to make this an attribute and not specifically an element as it allows better grouping especially if localized titles #6 is added. Side note Batman in most languages is still Batman also I could not find a series actually called "The Batman"

<Series>The Batman</Series>
<TitleSort>Batman</TitleSort>
<LocalizedTitle>The Batman</LocalizedTitle>
<LocalizedTitleScript>English</LocalizedTitleScript>

vs

<Series lang="eng" sort="Batman">The Batman</Series>

@gotson
Copy link
Member Author

gotson commented Jan 21, 2022

I think it might be better to make this an attribute and not specifically an element as it allows better grouping especially if localized titles #6 is added. Side note Batman in most languages is still Batman also I could not find a series actually called "The Batman"

<Series>The Batman</Series>
<TitleSort>Batman</TitleSort>
<LocalizedTitle>The Batman</LocalizedTitle>
<LocalizedTitleScript>English</LocalizedTitleScript>

vs

<Series lang="eng" sort="Batman">The Batman</Series>

You made me realize the big mistake I made, this whole thing is about the series name, not the book name, so it should be SeriesSort and not TitleSort !

I like your idea about using attributes, but on the other hand we are also trying to keep the schema in the same spirit as the existing one, in order not to have too many different ways of doing things depending on the elements.

@gotson gotson changed the title New element: TitleSort New element: SeriesSort Jan 21, 2022
@majora2007
Copy link

Just following up on this, are we good to go ahead with SeriesSort tag? I want to implement support in Kavita.

@gotson
Copy link
Member Author

gotson commented Mar 3, 2022

Just following up on this, are we good to go ahead with SeriesSort tag? I want to implement support in Kavita.

there's no planned support for providers yet, so that would be for manual editing?

@majora2007
Copy link

Yeah, I know many of my users are manually editing their metadata when ComicVine doesn't have it or MangaTagger. I have support to read the tag already in Kavita. We have a user tool, like comic-tagger, that writes the field out already.

@gotson
Copy link
Member Author

gotson commented Mar 3, 2022

Can you share the exact spec of this new tag you read and write already? A few forms have been mentioned above.

And what's the tool already writing it?

@majora2007
Copy link

I'm reading it exactly as Series works, so:
<SeriesSort>Adventure Time</SeriesSort>
via
<xs:element minOccurs="0" maxOccurs="1" default="" name="Series" type="xs:string" />

The tool that is writing it is Manga-Manager: https://github.com/ThePromidius/Manga-Manager/releases/tag/v0.4.1

(I'm not sure if the release has it, as the developer is in our discord and building it alongside community needs)

The reason why I would like it in the spec is that I have added support based on above conversation and I want to eventually allow metadata to be saved in the file (from our DB). I also have many users asking for something along the lines of this, so that they can have "The Batman" sort as "Batman".

@gotson
Copy link
Member Author

gotson commented Mar 3, 2022

I'm in favor of this. Do you want to send a PR with the changes, and we can approve on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking The change will generate a new minor version of the schema RFC Request for comments
Projects
None yet
Development

No branches or pull requests

3 participants