Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Implement oAuth credentials as environment variables #552

Open
3 tasks done
SanketDG opened this issue Jun 4, 2020 · 2 comments
Open
3 tasks done

Implement oAuth credentials as environment variables #552

SanketDG opened this issue Jun 4, 2020 · 2 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request.

Comments

@SanketDG
Copy link
Contributor

SanketDG commented Jun 4, 2020

Description

As a developer or someone who sets up the application,
I would want to easily set up the oAuth integrations that are already implemented.

Currently, given how django-allauth works by default, one has to go into the admin console
and create new oAuth apps.

Using settings.py for the application credentials is also supported by django-allauth and this aligns with https://12factor.net/config, so we should go ahead and implement that and load the settings through respective environment variables.

Definition of Done

  • Find all the oAuth Integrations used in this project.
  • For each oAuth integration, read credentials from the environment through settings.
  • Approval by 1 mentor.

Estimation

24 hours

@SanketDG SanketDG added Type: Enhancement New feature or request. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Jun 4, 2020
@satya7289
Copy link
Contributor

Do credentials for all type of Auth variables need in config file like Facebook, Google, slack etc.
@SanketDG

@SanketDG
Copy link
Contributor Author

SanketDG commented Jun 4, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants