From d27c1f213a0ebde27bbeed2048a6b28e783f0d34 Mon Sep 17 00:00:00 2001 From: Jan Mas Rovira Date: Thu, 20 Jun 2024 13:10:53 +0200 Subject: [PATCH] address review comments --- .../FromInternal/Analysis/TypeChecking/Error/Types.hs | 4 ++-- test/Compilation/Negative.hs | 2 +- tests/Compilation/negative/test006.juvix | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Juvix/Compiler/Internal/Translation/FromInternal/Analysis/TypeChecking/Error/Types.hs b/src/Juvix/Compiler/Internal/Translation/FromInternal/Analysis/TypeChecking/Error/Types.hs index edb286e1ce..30156e4141 100644 --- a/src/Juvix/Compiler/Internal/Translation/FromInternal/Analysis/TypeChecking/Error/Types.hs +++ b/src/Juvix/Compiler/Internal/Translation/FromInternal/Analysis/TypeChecking/Error/Types.hs @@ -206,7 +206,7 @@ instance ToGenericError WrongType where <+> thing <+> "has type:" <> line - <> indent' (ppCode opts' (err ^. wrongTypeActual ^. normalizedExpression)) + <> indent' (ppCode opts' (err ^. wrongTypeActual . normalizedExpression)) <> line <> "but is expected to have type:" <> line @@ -656,7 +656,7 @@ instance ToGenericError BadScope where i = getLoc (e ^. badScopeVar) var = e ^. badScopeVar msg :: Doc Ann = - annotate AnnImportant "Oops! This is a known bug in the juvix compiler." + annotate AnnImportant "Oops! This is a known bug in the Juvix compiler." <> line <> "Most likely, the inference algorithm inserted the variable" <+> ppCode opts' var diff --git a/test/Compilation/Negative.hs b/test/Compilation/Negative.hs index e4950e5762..c6fbf1f57a 100644 --- a/test/Compilation/Negative.hs +++ b/test/Compilation/Negative.hs @@ -51,7 +51,7 @@ tests = $(mkRelDir ".") $(mkRelFile "test005.juvix"), NegTest - "Test006: Ill scoped term (Thi is a bug. It should be positive)" + "Test006: Ill scoped term (This is a bug. It should be positive)" $(mkRelDir ".") $(mkRelFile "test006.juvix") ] diff --git a/tests/Compilation/negative/test006.juvix b/tests/Compilation/negative/test006.juvix index 4549f7bba4..831059c9ab 100644 --- a/tests/Compilation/negative/test006.juvix +++ b/tests/Compilation/negative/test006.juvix @@ -6,6 +6,3 @@ type Box (A : Type) := x : Box ((B : Type) → B → B) := box {_} λ {C x := x}; - --- (B : Type) → B → B --- (x1 : _@1) -> (x2 : _@2) -> _@3