From 7197baa2c9567ac3d2f073429e8f3898f01f929d Mon Sep 17 00:00:00 2001
From: Martin Hradil <mhradil@redhat.com>
Date: Tue, 19 Mar 2024 03:47:01 +0100
Subject: [PATCH] fixup insights build (#4929)

* fixup insights build

After #4866

looks like removing the singleton setting for react-router-dom was premature,
putting back, with an explicit version which is now required

No-Issue

* oh, the version field was just renamed, still accepts *

* update webpack check to cope with new fec format
---
 .github/workflows/pr-checks.yml | 2 +-
 config/webpack.base.config.js   | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/pr-checks.yml b/.github/workflows/pr-checks.yml
index 53bd8b6fdb..f22d0d26a9 100644
--- a/.github/workflows/pr-checks.yml
+++ b/.github/workflows/pr-checks.yml
@@ -145,7 +145,7 @@ jobs:
               perl -ne 'print unless /^[0-9a-f]{64,64}$/d' |
               grep -v '^Current branch:' |
               grep -v '^Waiting for ' |
-              grep -v '^Root folder:' > ~/webpack-config/"$version"/"$file".json
+              grep -v 'Root folder:' > ~/webpack-config/"$version"/"$file".json
           done
 
           popd
diff --git a/config/webpack.base.config.js b/config/webpack.base.config.js
index 287267b95e..2754da34f1 100644
--- a/config/webpack.base.config.js
+++ b/config/webpack.base.config.js
@@ -209,6 +209,11 @@ module.exports = (inputConfigs) => {
           exposes: {
             './RootApp': resolve(__dirname, '../src/entry-insights.tsx'),
           },
+          shared: [
+            {
+              'react-router-dom': { singleton: true, version: '*' },
+            },
+          ],
         },
       ),
     );