Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes report #32

Open
Palmer-JC opened this issue Sep 14, 2017 · 1 comment
Open

Fixes report #32

Palmer-JC opened this issue Sep 14, 2017 · 1 comment

Comments

@Palmer-JC
Copy link

I have been trying to use this. I found some fixes. They are small, so just reporting for now. They can be probably updated much faster by some else, then me forking / changing / and PRing.

In GIFEncoder.js:

  • line 148, should be sizeSet, not sizeset, causes exception when passing ImageData
  • The following lines need to be added to the end of download() to actually make it work:

var click = document.createEvent('MouseEvents');
click.initEvent('click', true, false);
templink.dispatchEvent(click);

@bills-appworks
Copy link

I faced problem of download() not work on Mozilla Firefox.
I try to fix and make patch based on following article of Stackoverflow:
https://stackoverflow.com/questions/32225904/programmatical-click-on-a-tag-not-working-in-firefox

My implement is templink element append under document root. It's work fine on Firefox.
But @Palmer-JC 's code seems to more better. I hope to repository taking his code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants