Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed of tspex #12

Open
morriso1 opened this issue Nov 26, 2021 · 2 comments
Open

Speed of tspex #12

morriso1 opened this issue Nov 26, 2021 · 2 comments

Comments

@morriso1
Copy link

Hi,
I've been finding tspex super useful for my work and really user friendly. Reading through the source code, I noticed that some of the specificity functions are written in a way that makes than slower than they could be. I had a go at rewriting a few functions and managed to get ~500x speed up testing_ts_funcs.pdf. At the moment, I have implemented them in a python package (https://github.com/morriso1/tspecscores), since I needed to easily access them for my own work.

Would you be interested in a pull request with these faster implementations?
@apcamargo
Copy link
Owner

Hi @morriso1
Thanks for your effort! I'm very interested in a PR :)

@morriso1
Copy link
Author

Sounds good! I'll start working on a PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apcamargo @morriso1