Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a "requirements" section in the readme #6

Open
lelutin opened this issue Apr 20, 2010 · 3 comments
Open

add a "requirements" section in the readme #6

lelutin opened this issue Apr 20, 2010 · 3 comments

Comments

@lelutin
Copy link

lelutin commented Apr 20, 2010

the readme file should list the requirements for running iphp.

So far, I can see PHP 5 >= 5.1 is needed because of use of the readline_callback_handler_install function. and, php-cli is also needed.

also, PHP must be compiled with option --with-readline

@apinstein
Copy link
Owner

Thanks for the info.

I guess it'd be possible to make it work without readline, but I am not sure you'd want to. It would be so painful to use... I will try to add this info to the requirements.

@lelutin
Copy link
Author

lelutin commented Apr 20, 2010

I encountered a problem while trying out iphp:

right after the welcome message, it says:

Fatal error: Call to undefined function readline_callback_handler_install() in /home/me/Desktop/apinstein-iphp-9070a44/iphp.php on line 420

php -v gives 5.2.6 and php -m says the "readline" module is active.

around line 420, the if clause checks for existance of the "readline" function but uses "readline_callback_handler_install".

changing the if to test for readline_callback_handler_install instead made the script run.

after fixing this, I can see that you are using a fallback to readline_callback_handler_install so maybe the requirements are not as high as php >= 5.1 ..

@apinstein
Copy link
Owner

Interesting. I am not sure why I check that way -- I looked in the php docs for readline_callback_handler_install and didn't see where it was not bundled with readline.

BUt if your patch works, that's great. I will look into it in the future for fixing it in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants