Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Crash on iOS in HaishinKit - Data.replaceSubrange(_:with:) #57

Open
1 of 2 tasks
kaz080 opened this issue Jun 3, 2024 · 4 comments
Open
1 of 2 tasks

[Bug]: Crash on iOS in HaishinKit - Data.replaceSubrange(_:with:) #57

kaz080 opened this issue Jun 3, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@kaz080
Copy link

kaz080 commented Jun 3, 2024

Version

v1.0.7

Which operating systems have you used?

  • Android
  • iOS

Environment that reproduces the issue

iPhone (13 Pro Max / 16.5.1)
Flutter 3.19.1

Is it reproducible in the example application?

Yes

RTMP Server

none

Reproduction steps

Randomly occurs during live streaming on iOS.

Expected result

Do not crash.

Actual result

Crash in HaishinKit: Data.replaceSubrange(_:with:).

2024-05-31 15 05 59

Additional context

This crash is reported in HaishinKit:
shogo4405/HaishinKit.swift#1077

And it seems to be fixed in HaishinKit version 1.8.0.
shogo4405/HaishinKit.swift#1406

The latest apivideo_live_stream 1.2.0 uses HaishinKit 1.7.3,
so it seems necessary to update HaishinKit to the latest version.

Relevant logs output

No response

@kaz080 kaz080 added the bug Something isn't working label Jun 3, 2024
@ThibaultBee
Copy link
Member

Hi,

Could you already upgrade to apivideo_live_stream 1.2.0?

Did you find something relevant to make it happen? So we can reproduce on our side.

@kaz080
Copy link
Author

kaz080 commented Jun 4, 2024

Hi @ThibaultBee,

Yes, we have upgrade apivideo_live_stream to 1.2.0 recently, because of another crash bug:
shogo4405/HaishinKit.swift#1238

We have not found any information on reproduction.
Based on this comment, a model with less memory might increase the reproduction rate.
shogo4405/HaishinKit.swift#1077 (comment)

@ThibaultBee
Copy link
Member

HaishinKit has been updated in apivideo/api.video-swift-live-stream@4a57e86

@ThibaultBee
Copy link
Member

The fix has been pushed to main. Could you test to reproduce this issue on the main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants