Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A+ LTI Tool v1.3: A+ sends unofficial points to the LTI Platform as if they were normal, accepted points #1294

Open
markkuriekkinen opened this issue Oct 20, 2023 · 0 comments
Open

A+ LTI Tool v1.3: A+ sends unofficial points to the LTI Platform as if they were normal, accepted points #1294

markkuriekkinen opened this issue Oct 20, 2023 · 0 comments
Labels
area: LTI LTI protocol (Learning Tools Interoperability, worldwide standard) area: points/grade Includes points and grader per user and for all effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team type: bug This is a bug
Milestone
v1.20.X patches i...

Comments

@markkuriekkinen
Copy link
Contributor

When using A+ as LTI Tool v1.3, if a student makes an unofficial submission (e.g., after the deadline), A+ sends the points to the LTI Platform (like Moodle) gradebook as if they were normal points. However, unofficial points should not affect grading, thus the LTI Platform should only receive zero points from unofficial submissions.

The send_lti_points() function doesn't seem to check the submission status at all, thus it only picks the points from it (even if the submission is unofficial).

a-plus/lti_tool/utils.py

Line 69 in 47d2f5c

(grade.set_score_given(best_submission.points)

@markkuriekkinen markkuriekkinen added type: bug This is a bug area: LTI LTI protocol (Learning Tools Interoperability, worldwide standard) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team area: points/grade Includes points and grader per user and for all labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: LTI LTI protocol (Learning Tools Interoperability, worldwide standard) area: points/grade Includes points and grader per user and for all effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate requester: team The issue is raised by a person inside the A+ developer team type: bug This is a bug
Projects
A+ sprints
Status: Todo
Milestone
v1.20.X patches in the autumn 2023
Development

No branches or pull requests
1 participant
@markkuriekkinen