-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error in readme #1692
Comments
@FranzBusch @gjcairo – Did you want to update the comments to reflect this? I guess all the parsing apis got annotated as deprecated, but not the serialization apis? |
IMO the docs are just wrong here |
Apologies, I'd missed this issue. I don't think the docs are wrong here.
However if you think it's worth mentioning, I can add something like:
|
Before opening a new issue, please double check the past issues (both open and
closed ones) to see if your problem has been discussed before and already
contains an answer/solution. Likewise, check the FAQ in the Documentation folder
for some common things -
https://github.com/apple/swift-protobuf/blob/main/Documentation/FAQ.md
Please be sure to include:
what OS you are developing on (Linux or macOS, including the version)
macOS
for macOS, what version of Xcode you are using (
xcodebuild -version
),for Linux, what version of Swift (
swift --version
)what version of Swift is your code set to compile with (i.e. from project
settings, etc.)
what branch/tag of SwiftProtobuf you are using (1.0.0, etc.)
*main
if you are getting compile errors, please be sure include all errors/warnings,
sometimes the error before the one you are stuck on is important.
lastly, if it all possible, provide a snippet of
.proto
and/or sourcethat shows the problem.
Thank you!
// Serialize to binary protobuf format: you can choose to serialize into
// any type conforming to SwiftProtobufContiguousBytes. For example:
let binaryData: Data = try info.serializedBytes()
let binaryDataAsBytes: [UInt8] = try info.serializedBytes()
should it be?
let binaryData: Data = try info.serializedData()
The text was updated successfully, but these errors were encountered: