Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using BuidlerPluginError instead of plain errors #191

Open
fvictorio opened this issue Aug 3, 2020 · 1 comment
Open

Consider using BuidlerPluginError instead of plain errors #191

fvictorio opened this issue Aug 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@fvictorio
Copy link

This isn't exactly a bug, but there wasn't a better option in the templates 😅

buidler-aragon throws plain errors, like this one:

throw Error(`Invalid bump from ${prevVersion} to ${nextVersion}`)

It's better to throw BuidlerPluginErrors from Buidler plugins, since that lets buidler give better feedback to the user. Relevant section in the docs: https://buidler.dev/advanced/building-plugins.html#throwing-errors-from-your-plugins

@fvictorio fvictorio added the bug Something isn't working label Aug 3, 2020
@welcome
Copy link

welcome bot commented Aug 3, 2020

Thanks for opening your first issue in aragonCLI! Someone will circle back soon ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant