Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildQueue should allow for multiple instances of same task #242

Open
kornysietsma opened this issue Sep 6, 2017 · 0 comments
Open

BuildQueue should allow for multiple instances of same task #242

kornysietsma opened this issue Sep 6, 2017 · 0 comments

Comments

@kornysietsma
Copy link

The BuildQueue.get_details() method assumes there will only be one queued item for a given task, if there are multiple queued items it will return the last one.

This scenario is entirely possible - we have a single integration test job that is triggered by several upstream jobs, and if people commit to more than one upstream build we can easily see 2 or 3 queued jobs; in fact I'm trying to write code to detect this specific scenario!

(I'd raise a PR, but this requires some thoughts about how it would impact other methods that call get_details - it might be a breaking change for some users.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants