From bf80c3e74bd15269d37968037f2320d43c0a019a Mon Sep 17 00:00:00 2001
From: Alon Gluz <alon.gluzman@frontegg.com>
Date: Thu, 26 Sep 2024 12:33:32 +0300
Subject: [PATCH] add ns as well

---
 examples/linkerd/README.md    | 16 ++++++++++++----
 examples/linkerd/ingress.yaml | 21 ---------------------
 2 files changed, 12 insertions(+), 25 deletions(-)
 delete mode 100644 examples/linkerd/ingress.yaml

diff --git a/examples/linkerd/README.md b/examples/linkerd/README.md
index 6de4c3b..5f2a2f6 100644
--- a/examples/linkerd/README.md
+++ b/examples/linkerd/README.md
@@ -64,14 +64,22 @@ Create three Services required for canary based rollout stratedy
 kubectl apply -f service.yaml
 ```
 
-## Step 7 - Create an example Rollout
+## Step 7 - Create the services required for traffic split 
+
+Add Linkerd annotaions to the namespace where the services are deployed
+
+```shell
+kubectl apply -f namespace.yaml
+```
+
+## Step 8 - Create an example Rollout
 
 Deploy a rollout to get the initial version.
-``shell
+```shell
 kubectl apply -f rollout.yaml
 ```
 
-## Step 8 - Watch the rollout
+## Step 9 - Watch the rollout
 ```shell
-kubectl -n default get httproute.gateway.networking.k8s.io/argo-rollouts-http-route -o custom-columns=NAME:.metadata.name,PRIMARY_SERVICE:.spec.rules[0].backendRefs[0].name,PRIMARY_WEIGHT:.spec.rules[0].backendRefs[0].weight,CANARY_SERVICE:.spec.rules[0].backendRefs[1].name,CANARY_WEIGHT:.spec.rules[0].backendRefs[1].weight
+watch "kubectl -n default get httproute.gateway.networking.k8s.io/argo-rollouts-http-route -o custom-columns=NAME:.metadata.name,PRIMARY_SERVICE:.spec.rules[0].backendRefs[0].name,PRIMARY_WEIGHT:.spec.rules[0].backendRefs[0].weight,CANARY_SERVICE:.spec.rules[0].backendRefs[1].name,CANARY_WEIGHT:.spec.rules[0].backendRefs[1].weight"
 ```
diff --git a/examples/linkerd/ingress.yaml b/examples/linkerd/ingress.yaml
deleted file mode 100644
index c7ec9c5..0000000
--- a/examples/linkerd/ingress.yaml
+++ /dev/null
@@ -1,21 +0,0 @@
-# apiVersion: networking.k8s.io/v1beta1 # for k3s < v1.19
-apiVersion: networking.k8s.io/v1
-kind: Ingress
-metadata:
-  name: nginx
-  namespace: default
-  annotations:
-    ingress.kubernetes.io/ssl-redirect: "false"
-    linkerd.io/inject: enabled
-spec:
-  rules:
-    - host: localhost
-      http:
-        paths:
-          - path: /
-            pathType: Prefix
-            backend:
-              service:
-                name: argo-rollouts-service
-                port:
-                  number: 80