You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure if this is simply a documentation issue or could lead to weird errors since users source the provider from registry.terraform.io/argoproj-labs/argocd instead of the in-code advertised registry.terraform.io/oboukili/argocd.
old go module path
As long as Github redirects from the old repository location to the new one this isn't an issue, but we should migrate and import our own packages from the new repo location to not depend on the redirection anymore.
This however is a chicken-egg situation as changing the module's import path in go.mod will fail everything and has to be merged to main before we can fix it by updating the pkg references.
The text was updated successfully, but these errors were encountered:
the-technat
changed the title
Go module path & served registry path hasn't been migrated
Go module path & served registry path hasn't been migrated to new repository location
Oct 20, 2024
the-technat
changed the title
Go module path & served registry path hasn't been migrated to new repository location
Naming issues with moving the repository to a new location
Oct 20, 2024
Regarding the go module path: I'm not sure what side-affects fixing this has. Theoretically in go's world this would require a major version bump which would change the import path to include /v8 as suffix. But since we are in Terraform's world things might work a bit different?
We can also just rely on Github's repository redirection forever and leave everything as is.
There has already been work gone into this topic in #421 and #441.
The following two lines still use the "old" repo path:
old serve registry path
Not sure if this is simply a documentation issue or could lead to weird errors since users source the provider from
registry.terraform.io/argoproj-labs/argocd
instead of the in-code advertisedregistry.terraform.io/oboukili/argocd
.old go module path
As long as Github redirects from the old repository location to the new one this isn't an issue, but we should migrate and import our own packages from the new repo location to not depend on the redirection anymore.
This however is a chicken-egg situation as changing the module's import path in
go.mod
will fail everything and has to be merged tomain
before we can fix it by updating the pkg references.The text was updated successfully, but these errors were encountered: