Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming issues with moving the repository to a new location #473

Open
the-technat opened this issue Oct 20, 2024 · 1 comment
Open

Naming issues with moving the repository to a new location #473

the-technat opened this issue Oct 20, 2024 · 1 comment
Assignees
Labels
bug Something isn't working go Pull requests that update Go code

Comments

@the-technat
Copy link
Collaborator

the-technat commented Oct 20, 2024

There has already been work gone into this topic in #421 and #441.

The following two lines still use the "old" repo path:

old serve registry path

Not sure if this is simply a documentation issue or could lead to weird errors since users source the provider from registry.terraform.io/argoproj-labs/argocd instead of the in-code advertised registry.terraform.io/oboukili/argocd.

old go module path

As long as Github redirects from the old repository location to the new one this isn't an issue, but we should migrate and import our own packages from the new repo location to not depend on the redirection anymore.

This however is a chicken-egg situation as changing the module's import path in go.mod will fail everything and has to be merged to main before we can fix it by updating the pkg references.

@the-technat the-technat added bug Something isn't working go Pull requests that update Go code labels Oct 20, 2024
@the-technat the-technat changed the title Go module path & served registry path hasn't been migrated Go module path & served registry path hasn't been migrated to new repository location Oct 20, 2024
@the-technat the-technat self-assigned this Oct 20, 2024
@the-technat the-technat changed the title Go module path & served registry path hasn't been migrated to new repository location Naming issues with moving the repository to a new location Oct 20, 2024
@the-technat
Copy link
Collaborator Author

Regarding the go module path: I'm not sure what side-affects fixing this has. Theoretically in go's world this would require a major version bump which would change the import path to include /v8 as suffix. But since we are in Terraform's world things might work a bit different?

We can also just rely on Github's repository redirection forever and leave everything as is.

Anyone already had some experience with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

No branches or pull requests

1 participant