Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending items for Pallas/Vesta <-> Bn256/Grumpkin switch #1078

Closed
storojs72 opened this issue Jan 25, 2024 · 0 comments · Fixed by #1099
Closed

Pending items for Pallas/Vesta <-> Bn256/Grumpkin switch #1078

storojs72 opened this issue Jan 25, 2024 · 0 comments · Fixed by #1099
Assignees

Comments

@storojs72
Copy link
Member

This issue is a "reduction" of #1018.

#1039 performs Pallas/Vesta <-> Bn256/Grumpkin replacement in significant amount of codebase, specifically in unit-tests, which is important for generating the test-vectors, however Repl, Examples and Benchmarks are still left untouched. More specifically, following source files still use Pallas/Vesta:

<Sources>

/src/proof/nova.rs
/src/field.rs
/src/cli/mod.rs
/src/cli/field_data.rs
/src/cli/zstore.rs

<Examples>

/examples/tp_table.rs
/examples/sha256_nivc.rs
/examples/sha256_ivc.rs
/examples/circom.rs

<Benchmarks>

/benches/end2end.rs
/benches/fibonacchi.rs
/benches/public_parameters.rs
/benches/sha256.rs
/benches/common/fib.rs
/benches/synthesis.rs

Since Repl, Examples and Benchmarks are user-facing programs (and hence sensitive), it is better to have separate PR for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant