Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PerfConfig #1111

Closed
arthurpaulino opened this issue Feb 9, 2024 · 1 comment · Fixed by #1144
Closed

Refactor PerfConfig #1111

arthurpaulino opened this issue Feb 9, 2024 · 1 comment · Fixed by #1144

Comments

@arthurpaulino
Copy link
Member

Our PerfConfig can better represent the parallelizations that we have:

  • Parallel witness generation for the slots
  • Parallel witness generation for the frames within a MultiFrame
  • Folding in parallel with witness generation

Therefore, our PerfConfig would better capture what actually happens with more meaningful attributes. For example:

struct PerfConfig {
  slots: Flow,
  frames: Flow,
  witgen_vs_folding: Flow,
}

Then, our canned configs would be:

  • FullySequential
  • ParallelSlots
  • ParallelFrames
  • ParallelWitGenVsFolding
  • FullyParallel
@samuelburnham
Copy link
Member

Sounds great, please ping me for review on the eventual PR so I can check it integrates with the user config and env vars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants