Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arecibo feature #613

Closed
porcuquine opened this issue Aug 15, 2023 · 2 comments · Fixed by #620
Closed

Arecibo feature #613

porcuquine opened this issue Aug 15, 2023 · 2 comments · Fixed by #620
Assignees

Comments

@porcuquine
Copy link
Collaborator

We should create an arecibo feature that allows swapping in arecibo for Nova, so we can iterate on interfaces using arecibo as a lab for that purpose.

@huitseeker
Copy link
Member

I don’t think this is likely to work: arecibo needs to replicate https://github.com/lurk-lab/nova/tree/dev, which means it needs to depend on Nova master (to bypass the release latency).

Here’s the diff between Nova-released and Nova-master as of today: https://github.com/microsoft/nova/compare/b42938e..a951505

TL;DR, the difference will quickly require source discrepancies based on whether Lurk sits on top of Nova released or arecibo. Arecibo as the main dependency of Lurk (with a branch compatible with Nova-released, maintained as time permits) seems less to involve a lot less work.

@porcuquine
Copy link
Collaborator Author

Okay, let's instead fully switch to a Git dependency on Arecibo, for now — to be replaced with release versions as it matures. In other words, no feature flag, straight up replacing our backend to keep things simple.

@samuelburnham samuelburnham linked a pull request Aug 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants