Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Circom coprocessor use arguments #789

Open
arthurpaulino opened this issue Oct 24, 2023 · 8 comments
Open

Make Circom coprocessor use arguments #789

arthurpaulino opened this issue Oct 24, 2023 · 8 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@arthurpaulino
Copy link
Member

The PoC implementation of the Circom coprocessor doesn't take arguments, but we'd want it to.

@huitseeker huitseeker added the help wanted Extra attention is needed label Oct 24, 2023
@huitseeker
Copy link
Member

@arthurpaulino is this still active post #799, #756 et al?

@arthurpaulino
Copy link
Member Author

Yes, this issue is specific to the Circom coprocessor itself, which wasn't changed when adapted to LEM

@tchataigner
Copy link
Member

I was about to tackle this but it seems that I got confused in lexical terms. When referring to arguments do we mean inputs or parameters?

As the main entrypoint does not allow for parameters I'm guessing we refer to inputs, but I just want to make sure.

@arthurpaulino
Copy link
Member Author

@tchataigner we mean the arguments we pass in a Lurk program like foo in (sha256 foo)

@tchataigner
Copy link
Member

Alright so arguments is a lurk term. And, deducing that those arguments are then what we use as inputs in Circom.

@huitseeker
Copy link
Member

@tchataigner yes

@tchataigner tchataigner self-assigned this Jan 18, 2024
@tchataigner
Copy link
Member

Hey everyone! Quick follow-up on this. After some consideration, it seems that we can not really create a 1 to 1 relationship between the awaited circom signals and our lurk arguments. So the information about the arity of a CircomGadget and how to handle them will have to be declarative on the developer side.

#997 will show off how that works for now. I have an update to push by EOD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants