Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUR-12] CI: check for unused dependencies #983

Closed
huitseeker opened this issue Dec 20, 2023 · 2 comments · Fixed by #1070
Closed

[LUR-12] CI: check for unused dependencies #983

huitseeker opened this issue Dec 20, 2023 · 2 comments · Fixed by #1070
Labels
CI Related to our CI pipelines good first issue Good for newcomers help wanted Extra attention is needed

Comments

@huitseeker
Copy link
Member

huitseeker commented Dec 20, 2023 •
edited
Loading

I just spotted that the peekmore dependency is unused.

We could check this as a daily job with something like:

LUR-12
@huitseeker huitseeker added help wanted Extra attention is needed good first issue Good for newcomers CI Related to our CI pipelines labels Dec 20, 2023
@huitseeker huitseeker changed the title CI: check for unused dependencies [LUR-12] CI: check for unused dependencies Dec 20, 2023
huitseeker added a commit to huitseeker/ci-workflows that referenced this issue Dec 23, 2023
@huitseeker
feat: add a workflow to check for unused dependencies
fdb49f6 
This should help close e.g. argumentcomputer/lurk-beta#983 downstream.
huitseeker added a commit to huitseeker/ci-workflows that referenced this issue Dec 23, 2023
@huitseeker
feat: add a workflow to check for unused dependencies
f8f47be 
This should help close e.g. argumentcomputer/lurk-beta#983 downstream.
@huitseeker huitseeker mentioned this issue Dec 23, 2023
Merged
@huitseeker
Copy link
Member Author

This becomes a simple integration once argumentcomputer/ci-workflows#6 merges /cc @samuelburnham

@huitseeker
Copy link
Member Author

huitseeker commented Jan 17, 2024 •
edited
Loading

This is solved in Arecibo, good run at:
https://github.com/lurk-lab/arecibo/actions/runs/7549231360

huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Jan 19, 2024
@huitseeker
ci: nightly GitHub Action workflow
9f6672f 
- Renames the nightly workflow test in '.github/workflows/nightly.yml'
- detects unused dependencies,
- detects Rust version becoming stale w.r.t. stable

Fixes argumentcomputer#983
@huitseeker huitseeker mentioned this issue Jan 19, 2024
Merged
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Jan 19, 2024
@huitseeker
ci: nightly GitHub Action workflow
251a825 
- Renames the nightly workflow test in '.github/workflows/nightly.yml'
- detects unused dependencies,
- detects Rust version becoming stale w.r.t. stable

Fixes argumentcomputer#983
huitseeker added a commit to huitseeker/lurk-rs that referenced this issue Jan 19, 2024
@huitseeker
ci: nightly GitHub Action workflow
ed5507b 
- Renames the nightly workflow test in '.github/workflows/nightly.yml'
- detects unused dependencies,
- detects Rust version becoming stale w.r.t. stable

Fixes argumentcomputer#983
github-merge-queue bot pushed a commit that referenced this issue Jan 19, 2024
@huitseeker
ci: nightly GitHub Action workflow (#1070)
3476fc7 
* ci: nightly GitHub Action workflow

- Renames the nightly workflow test in '.github/workflows/nightly.yml'
- detects unused dependencies,
- detects Rust version becoming stale w.r.t. stable

Fixes #983

* fix: inference.ag URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Related to our CI pipelines good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: nightly GitHub Action workflow huitseeker/lurk-rs
1 participant
@huitseeker